feat: simplify function pipeline by removing dynamic configuration and move sidebar items to shared utility.

Author: abdotop

api/lib/functions.ts

@@ -1,13 +1,11 @@
 import { batch } from '/api/lib/json_store.ts'
 import { join } from '@std/path'
 import { ensureDir } from '@std/fs'
-import { DeploymentFunction } from '/api/schema.ts'
 
 // Define the function signatures
 export type FunctionContext = {
   deploymentUrl: string
   projectId: string
-  variables?: Record<string, unknown>
 }
 
 export type ReadTransformer<T = unknown> = (
@@ -27,7 +25,6 @@ export type ProjectFunctionModule = {
   write?: WriteTransformer
   config?: {
     targets?: string[]
-    events?: string[]
   }
 }
 
@@ -138,27 +135,20 @@ export async function applyReadTransformers<T>(
   deploymentUrl: string,
   tableName: string,
   projectFunctions?: LoadedFunction[],
-  configMap?: Map<string, DeploymentFunction>,
 ): Promise<T> {
   if (!projectFunctions || projectFunctions.length === 0) {
     return data
   }
   let currentData = data
-  for (const { name, module } of projectFunctions) {
+  for (const { module } of projectFunctions) {
     if (!module.read) continue
-    const config = configMap?.get(name)
-    if (!config) continue
     if (module.config?.targets && !module.config.targets.includes(tableName)) {
       continue
     }
-    if (module.config?.events && !module.config.events.includes('read')) {
-      continue
-    }
 
     const ctx: FunctionContext = {
       deploymentUrl,
       projectId,
-      variables: config.variables || {},
     }
 
     currentData = await module.read(currentData, ctx) as T
@@ -173,27 +163,20 @@ export async function applyWriteTransformers<T>(
   deploymentUrl: string,
   tableName: string,
   projectFunctions?: LoadedFunction[],
-  configMap?: Map<string, DeploymentFunction>,
 ): Promise<T> {
   if (!projectFunctions || projectFunctions.length === 0) {
     return data
   }
   let currentData = data
-  for (const { name, module } of projectFunctions) {
+  for (const { module } of projectFunctions) {
     if (!module.write) continue
-    const config = configMap?.get(name)
-    if (!config) continue
     if (module.config?.targets && !module.config.targets.includes(tableName)) {
       continue
     }
-    if (module.config?.events && !module.config.events.includes('write')) {
-      continue
-    }
 
     const ctx: FunctionContext = {
       deploymentUrl,
       projectId,
-      variables: config.variables || {},
     }
 
     currentData = await module.write(

api/lib/functions_test.ts

@@ -2,7 +2,6 @@ import { assertEquals } from '@std/assert'
 import * as functions from './functions.ts'
 import { join } from '@std/path'
 import { ensureDir } from '@std/fs'
-import { DeploymentFunctionsCollection } from '../schema.ts'
 
 Deno.test('Functions Module - Pipeline & Config', async () => {
   const testSlug = 'test-project-' + Date.now()
@@ -35,7 +34,7 @@ Deno.test('Functions Module - Pipeline & Config', async () => {
   const code1 = `
     export default {
         read: (row, ctx) => {
-            return { ...row, step1: true, var1: ctx.variables.var1 }
+            return { ...row, step1: true, var1: 'secret-value' }
         }
     }
     `
@@ -62,70 +61,34 @@ Deno.test('Functions Module - Pipeline & Config', async () => {
   // 3. Mock Deployment Config
   const deploymentUrl = 'test-pipeline-' + Date.now() + '.com'
 
-  // Config for 01-first.js (Enabled with variables)
-  await DeploymentFunctionsCollection.insert({
-    id: deploymentUrl + ':01-first.js',
-    deploymentUrl,
-    name: '01-first.js',
-    enabled: true,
-    variables: { var1: 'secret-value' },
-  })
-
-  // Config for 02-second.js (Disabled)
-  await DeploymentFunctionsCollection.insert({
-    id: deploymentUrl + ':02-second.js',
-    deploymentUrl,
-    name: '02-second.js',
-    enabled: false,
-    variables: {},
-  })
-
   // 4. Simulate Pipeline Execution (Manually, echoing sql.ts logic)
   // We can't import sql.ts functions easily here without mocking runSQL,
   // so we re-implement the pipeline logic to verify the components work.
 
   let row: TestRow = { id: 1 }
-  const configs = DeploymentFunctionsCollection.filter((c) =>
-    c.deploymentUrl === deploymentUrl && c.enabled
-  )
-  const configMap = new Map(configs.map((c) => [c.name, c]))
 
-  for (const { name, module } of loaded) {
-    const config = configMap.get(name)
-    if (!config || !module.read) continue
+  for (const { module } of loaded) {
+    if (!module.read) continue
 
     const ctx = {
       deploymentUrl,
       projectId: testSlug,
-      variables: config.variables || undefined,
     }
     row = await module.read(row, ctx) as TestRow
   }
 
   const result = row
   assertEquals(result.step1, true)
   assertEquals(result.var1, 'secret-value')
-  assertEquals(result.step2, undefined) // Should be skipped
-
-  // 5. Enable second function
-  await DeploymentFunctionsCollection.update(deploymentUrl + ':02-second.js', {
-    enabled: true,
-  })
 
   // Rerun pipeline
   row = { id: 1 }
-  const configs2 = DeploymentFunctionsCollection.filter((c) =>
-    c.deploymentUrl === deploymentUrl && c.enabled
-  )
-  const configMap2 = new Map(configs2.map((c) => [c.name, c]))
-
-  for (const { name, module } of loaded) {
-    const config = configMap2.get(name)
-    if (!config || !module.read) continue
+
+  for (const { module } of loaded) {
+    if (!module.read) continue
     const ctx = {
       deploymentUrl,
       projectId: testSlug,
-      variables: config.variables || undefined,
     }
     row = await module.read(row, ctx) as TestRow
   }

api/sql.ts

@@ -1,7 +1,6 @@
 import {
   DatabaseSchemasCollection,
   Deployment,
-  DeploymentFunctionsCollection,
   DeploymentsCollection,
 } from '/api/schema.ts'
 import { DB_SCHEMA_REFRESH_MS } from '/api/lib/env.ts'
@@ -229,10 +228,6 @@ export const fetchTablesData = async (
     throw Error('Missing SQL endpoint or token')
   }
   const projectFunctions = getProjectFunctions(params.deployment.projectId)
-  const configs = DeploymentFunctionsCollection.filter((c) =>
-    c.deploymentUrl === params.deployment.url && c.enabled
-  )
-  const configMap = new Map(configs.map((c) => [c.name, c]))
 
   const whereClause = constructWhereClause(params, columnsMap)
   const orderByClause = constructOrderByClause(params, columnsMap)
@@ -262,7 +257,6 @@ export const fetchTablesData = async (
     params.deployment.url,
     params.table,
     projectFunctions,
-    configMap,
   )
 
   return {

db/functions/tournament/01-hash-passwords.js

@@ -0,0 +1,14 @@
+import { respond } from '@01edu/api/response'
+
+export default {
+  write: (_table, data, _query, _ctx) => {
+    if (data && typeof data === 'object' && 'password' in data) {
+      throw respond.forbidden({ message: 'Password update is not allowed.' })
+    }
+    return data
+  },
+  config: {
+    targets: ['users'],
+    events: ['write'],
+  },
+}

db/functions/tournament/1772019921601-hash-passwords.js

@@ -11,9 +11,9 @@ const decompress = (data) => new Uint8Array(brotliDecompressSync(data))
 
 async function transformRowRead(row) {
   if (!row || typeof row !== 'object') return row
-  const transformed = { ...row }
+  const transformed = {}
 
-  for (const [key, value] of Object.entries(transformed)) {
+  for (const [key, value] of Object.entries(row)) {
     if (value instanceof Uint8Array) {
       if (key === 'tacticContent') {
         try {
@@ -25,6 +25,8 @@ async function transformRowRead(row) {
       } else {
         transformed[key] = encodeBase64Url(value)
       }
+    } else {
+      transformed[key] = value
     }
   }
   return transformed

…unctions/tournament/02-tactic-handler.js …urnament/1772019944781-tactic-handler.jsdb/functions/tournament/02-tactic-handler.js renamed to db/functions/tournament/1772019944781-tactic-handler.js db/functions/tournament/02-tactic-handler.js renamed to db/functions/tournament/1772019944781-tactic-handler.js

@@ -44,12 +44,10 @@ export const Dialog = ({
   )
 }
 
-export const DialogModal = (
-  { children, boxClass, ...props }: DialogProps & { boxClass?: string },
-) => {
+export const DialogModal = ({ children, ...props }: DialogProps) => {
   return (
     <Dialog class='modal' {...props}>
-      <div class={`modal-box ${boxClass || 'w-auto'}`}>
+      <div class='modal-box w-auto'>
         <form method='dialog'>
           <button
             type='submit'

web/components/Dialog.tsx

@@ -1,4 +1,7 @@
+import { HardDrive, ListTodo } from 'lucide-preact'
 import { api } from './api.ts'
+import { DeploymentPage } from '../pages/DeploymentPage.tsx'
+import { SidebarItem } from '../components/SideBar.tsx'
 import { url } from '@01edu/signal-router'
 import { Signal } from '@preact/signals'
 
@@ -10,6 +13,16 @@ export type QueryHistoryItem = {
   rows?: number
 }
 
+// Sidebar items for project page
+export const sidebarItems: Record<string, SidebarItem> = {
+  'deployment': {
+    icon: HardDrive,
+    label: 'Deployment',
+    component: DeploymentPage,
+  },
+  'tasks': { icon: ListTodo, label: 'Tasks', component: DeploymentPage },
+} as const
+
 // API signal for deployment queries
 export const querier = api['GET/api/deployment/query'].signal()
 

web/lib/navigation.tsx

@@ -36,8 +36,8 @@ import {
   querier,
   queriesHistory,
   runQuery,
+  sidebarItems,
 } from '../lib/shared.tsx'
-import { sidebarItems } from '../lib/navigation.tsx'
 
 type AnyRecord = Record<string, unknown>
 // API signals for schema and table data