Skip to content

Mission Statement I: Feedback #1

@fbscott

Description

@fbscott

Great job on this submission!

This feedback is not necessarily comprehensive, but should give you insight into at least one aspect of the code that could be praised or enhanced.

HTML

Meta

Nice work! It's always important to inform the browser that you intend to scale your web page to match the viewport. Many people overlook this simple line.

<meta name="viewport" content="width=device-width, initial-scale=1.0">

Semantic Markup

Nice job using semantic markup and class names: <header>, <main>, etc., but don't forget about that <footer>.

WDD-131/index.html

Lines 12 to 34 in b87f65c

<header>
<h1>Brigham Young University-Idaho</h1>
<h2>Mission Statement</h2>
</header>
<main>
<section class="mission-text">
<p>
Brigham Young University-Idaho was founded and is supported and guided by
The Church of Jesus Christ of Latter-day Saints. Its mission is to develop
disciples of Jesus Christ who are leaders in their homes, the Church,
and their communities.
</p>
<p>The university does this by:</p>
<ul>
<li>Building testimonies of the restored gospel of Jesus Christ and fostering its principles in a wholesome academic, cultural, and social environment.</li>
<li>Providing a high-quality education that prepares students of diverse interests and abilities for lifelong learning and employment.</li>
<li>Serving as many students as possible within resource constraints.</li>
<li>Delivering education that is affordable for students and the Church.</li>
</ul>
</section>
</main>

I would have used an <ol> here to more accurately replicate the look of the mockup.

WDD-131/index.html

Lines 27 to 32 in b87f65c

<ul>
<li>Building testimonies of the restored gospel of Jesus Christ and fostering its principles in a wholesome academic, cultural, and social environment.</li>
<li>Providing a high-quality education that prepares students of diverse interests and abilities for lifelong learning and employment.</li>
<li>Serving as many students as possible within resource constraints.</li>
<li>Delivering education that is affordable for students and the Church.</li>
</ul>

CSS

Your submission isn’t a perfect match, but it closely resembles the design. There are a few nitpicky things, but all in all, this is a very good attempt at matching the Mission Statement!

See the screenshot below for a visual comparison. Factors taken into account were things like: color, margin/padding, font style/weight, indentation, etc. This is not a comprehensive list, but it should give you insight into what I was evaluating for this submission.

Image

Code Quality

Your code is easy to read and understand. Developers who might pick up where you left off would have no problems maintaining this project.

One thing I would change, however, is to move your projects into subdirectories. I noticed your Mission Statement I work is in the root. This will make it difficult to maintain when Mission Statement II comes along, and the following week's work, etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions