Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs to support large files (>1MB) #10

Open
pilcherd opened this issue Jul 3, 2019 · 11 comments
Open

Needs to support large files (>1MB) #10

pilcherd opened this issue Jul 3, 2019 · 11 comments
Labels
enhancement New feature or request

Comments

@pilcherd
Copy link

pilcherd commented Jul 3, 2019

My first attempt to open a file failed and the error shown reports that the app does not support a file greater than 1MB.

IMO This is an 'essential' feature for a notepad alternative.

Keep up the good work though. Thanks.

@0x7c13
Copy link
Owner

0x7c13 commented Jul 4, 2019

I do agree it is better to support large files but considering the work that I need to at this moment, I have to put it into my backlog for now. I would say, give me sometime and I will get back to this.

My plan on this would be:

Plan A:

  • Phase 1: For large files, Notepads read first 1MB or so and render that part in read-only mode.

  • Phase 2: For large files that opened with Notepads, Notepads use another implementation of the text editor control (potentially Monaco Editor: https://microsoft.github.io/monaco-editor/). So it should have the same performance for small files but can open/edit large files.

  • Phase 3: Check WinUI 3.0 status to see if any solution can be found to tackle this issue natively.

Plan B:

  • Implement pagination myself.

Plan C (Highly unlikely):

  • Implement my own eidt box using Win2D.

Sounds good?

More to read:
CommunityToolkit/WindowsCommunityToolkit#2858
microsoft/microsoft-ui-xaml#108

@0x7c13 0x7c13 added the enhancement New feature or request label Jul 4, 2019
@x3haloed
Copy link

x3haloed commented Jul 24, 2019

Maybe this is naive, but is it possible to (relatively) simply implement pagination by moving forward and backward through a FileStream in correlation to the scroll position?

edit: I just saw your reference to #6, which helps me understand why it's not such a simple problem.

@0x7c13
Copy link
Owner

0x7c13 commented Jul 25, 2019

@x3haloed The blocking issue is around ScrollViewer instead of RichEditBox. Actually RichEditBox can work with fairly large file but the ScrollViewer just cannot handle the size of the rendering. Believe it or not, if you set Font size to be 1-2, you can actually paste whole more content into Notepads.

@yaira2
Copy link

yaira2 commented Jan 14, 2020

There is an issue in the WinUI repository for this microsoft/microsoft-ui-xaml#1842.

@ivanjx
Copy link

ivanjx commented Oct 11, 2021

@Hexaae
Copy link

Hexaae commented Jul 3, 2022

Uhm... estimated time? 3 years have passed and this should have top priority IMHO

@yaira2
Copy link

yaira2 commented Jul 3, 2022

Uhm... estimated time? 3 years have passed and this should have top priority IMHO

Microsoft still doesn't support this scenario.

@bcutter
Copy link

bcutter commented Sep 13, 2023

Great. Finally a really beautiful, dark mode supporting (basically perfect) notepad for Win 10. But with this 1 MB file size limitation, it's simply not usable. Unfortunately had to remove Notepads again because of this, too bad.

@l0g4n1337
Copy link

F ... I love this app but ... srsly this nneed to be solved, 3 yrs passed!

@bcutter
Copy link

bcutter commented Nov 28, 2023

I upgraded to Win 11 and use the native editor (Notepad) again (my primary use-case for Notepads was the dark mode which the native one provides too on Win 11). Upgrade took me less then 3 years. Goodbye.

@foreachthing
Copy link

Wow ... thought this was just bothering me ... nope. Back to Notepad3. Keep it up, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants