Skip to content

Commit 32921cb

Browse files
author
wutali
committed
Fix title bug
1 parent c146f5b commit 32921cb

File tree

8 files changed

+42
-41
lines changed

8 files changed

+42
-41
lines changed

‎src/components/meta/BasicMeta.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import Head from "next/head";
12
import config from "../../lib/config";
23

34
type Props = {
@@ -15,7 +16,7 @@ export default function BasicMeta({
1516
url,
1617
}: Props) {
1718
return (
18-
<>
19+
<Head>
1920
<title>
2021
{title ? [title, config.site_title].join(" | ") : config.site_title}
2122
</title>
@@ -33,6 +34,6 @@ export default function BasicMeta({
3334
/>
3435
{author ? <meta name="author" content={author} /> : null}
3536
<link rel="canonical" href={config.base_url + url} />
36-
</>
37+
</Head>
3738
);
3839
}

‎src/components/meta/JsonLdMeta.tsx

+17-14
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { BlogPosting } from "schema-dts";
22
import { jsonLdScriptProps } from "react-schemaorg";
33
import config from "../../lib/config";
4-
import { parseISO, formatISO } from "date-fns";
4+
import { formatISO } from "date-fns";
5+
import Head from "next/head";
56

67
type Props = {
78
url: string;
@@ -22,18 +23,20 @@ export default function JsonLdMeta({
2223
description,
2324
}: Props) {
2425
return (
25-
<script
26-
{...jsonLdScriptProps<BlogPosting>({
27-
"@context": "https://schema.org",
28-
"@type": "BlogPosting",
29-
mainEntityOfPage: config.base_url + url,
30-
headline: title,
31-
keywords: keywords ? undefined : keywords.join(","),
32-
datePublished: formatISO(date),
33-
author: author,
34-
image: image,
35-
description: description,
36-
})}
37-
/>
26+
<Head>
27+
<script
28+
{...jsonLdScriptProps<BlogPosting>({
29+
"@context": "https://schema.org",
30+
"@type": "BlogPosting",
31+
mainEntityOfPage: config.base_url + url,
32+
headline: title,
33+
keywords: keywords ? undefined : keywords.join(","),
34+
datePublished: formatISO(date),
35+
author: author,
36+
image: image,
37+
description: description,
38+
})}
39+
/>
40+
</Head>
3841
);
3942
}

‎src/components/meta/OpenGraphMeta.tsx

+7-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import Head from "next/head";
12
import config from "../../lib/config";
23

34
type Props = {
@@ -13,7 +14,7 @@ export default function OpenGraphMeta({
1314
image,
1415
}: Props) {
1516
return (
16-
<>
17+
<Head>
1718
<meta property="og:site_name" content={config.site_title} />
1819
<meta property="og:url" content={config.base_url + url} />
1920
<meta
@@ -24,8 +25,11 @@ export default function OpenGraphMeta({
2425
property="og:description"
2526
content={description ? description : config.site_description}
2627
/>
27-
<meta property="og:image" content={config.base_url + "/og_image.png"} />
28+
<meta
29+
property="og:image"
30+
content={image ? image : config.base_url + "/og_image.png"}
31+
/>
2832
<meta property="og:type" content="article" />
29-
</>
33+
</Head>
3034
);
3135
}

‎src/components/meta/TwitterCardMeta.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import config from "../../lib/config";
2+
import Head from "next/head";
23

34
type Props = {
45
url: string;
@@ -7,7 +8,7 @@ type Props = {
78
};
89
export default function TwitterCardMeta({ url, title, description }: Props) {
910
return (
10-
<>
11+
<Head>
1112
<meta property="twitter:card" content="summary_large_image" />
1213
<meta property="twitter:site" content={config.twitter_account} />
1314
<meta property="twitter:url" content={config.base_url + url} />
@@ -19,6 +20,6 @@ export default function TwitterCardMeta({ url, title, description }: Props) {
1920
property="twitter:description"
2021
content={description ? description : config.site_description}
2122
/>
22-
</>
23+
</Head>
2324
);
2425
}

‎src/pages/index.tsx

+3-5
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@ import TwitterCardMeta from "../components/meta/TwitterCardMeta";
88
export default function Index() {
99
return (
1010
<Layout>
11-
<Head>
12-
<BasicMeta url={"/"} />
13-
<OpenGraphMeta url={"/"} />
14-
<TwitterCardMeta url={"/"} />
15-
</Head>
11+
<BasicMeta url={"/"} />
12+
<OpenGraphMeta url={"/"} />
13+
<TwitterCardMeta url={"/"} />
1614
<div className="container">
1715
<div>
1816
<h1>

‎src/pages/posts/index.tsx

+3-5
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,9 @@ export default function Index({ posts, tags, pagination }: Props) {
2222
const title = "All posts";
2323
return (
2424
<Layout>
25-
<Head>
26-
<BasicMeta url={url} title={title} />
27-
<OpenGraphMeta url={url} title={title} />
28-
<TwitterCardMeta url={url} title={title} />
29-
</Head>
25+
<BasicMeta url={url} title={title} />
26+
<OpenGraphMeta url={url} title={title} />
27+
<TwitterCardMeta url={url} title={title} />
3028
<PostList posts={posts} tags={tags} pagination={pagination} />
3129
</Layout>
3230
);

‎src/pages/posts/page/[page].tsx

+3-5
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,9 @@ export default function Page({ posts, tags, pagination, page }: Props) {
2323
const title = "All posts";
2424
return (
2525
<Layout>
26-
<Head>
27-
<BasicMeta url={url} title={title} />
28-
<OpenGraphMeta url={url} title={title} />
29-
<TwitterCardMeta url={url} title={title} />
30-
</Head>
26+
<BasicMeta url={url} title={title} />
27+
<OpenGraphMeta url={url} title={title} />
28+
<TwitterCardMeta url={url} title={title} />
3129
<PostList posts={posts} tags={tags} pagination={pagination} />
3230
</Layout>
3331
);

‎src/pages/posts/tags/[[...slug]].tsx

+3-5
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,9 @@ export default function Index({ posts, tag, pagination, page }: Props) {
2323
const title = tag.name;
2424
return (
2525
<Layout>
26-
<Head>
27-
<BasicMeta url={url} title={title} />
28-
<OpenGraphMeta url={url} title={title} />
29-
<TwitterCardMeta url={url} title={title} />
30-
</Head>
26+
<BasicMeta url={url} title={title} />
27+
<OpenGraphMeta url={url} title={title} />
28+
<TwitterCardMeta url={url} title={title} />
3129
<TagPostList posts={posts} tag={tag} pagination={pagination} />
3230
</Layout>
3331
);

0 commit comments

Comments
 (0)