Stat sub and heal commands use the wrong value to calculate percentage

[mark-b5]

The following commands

• stat_sub
• stat_heal
• npc_statsub
• npc_statheal
• Others potentially?

All do something along the lines of

const current = npc.levels[stat];
const subbed = current - (constant + (current * percent) / 100);

They take a percent argument and then modify the stat by currentstat * percent / 100. This is no good!!!!

The proper behavior should be modifying the stat by basestat * percent / 100. You can see an example of this in the following runescript

Here, stat_heal(hitpoints,0,100) should heal the player to full hitpoints. However in our current engine, if we run the following debugproc while at 99/99 hp,

[debugproc,dmg_heal]
if (p_finduid(uid) = true) {
    p_delay(1);
    stat_sub(hitpoints, 98, 0);
    p_delay(1);
    stat_heal(hitpoints,0,100);
}

the player is left at 2/99 hitpoints rather than 99/99 hitpoints.

All these engine commands needs to be updated, and then all calls in runescript that pass in a percent parameter need to be updated to match the new engine behavior

So, in short:

1. Figure out if there are more than these 4 commands where this problem exists
2. Update these commands to use base_stat rather than current_stat when multiplying by percentage
3. Sort through all calls to these commands in runescript and check if they need updated to match new behavior

[hex-agon]

Might also consider reworking this logic inside STAT_HEAL and move it into Player.changeStat or into runescript (think there was some discussion around if they could clear heropoints from runescript).

if (stat === 3 && player.levels[3] >= player.baseLevels[3]) {
    player.heroPoints.clear();
}

[mark-b5]

I think it should be inside Player.changeStat because hp regen is all handled in engine

Wasn't there some discussion that resetting hp when npcs heal to full isn't even authentic before osrs?

It also makes sense to expose herePoints.clear() to runescript also, but not for this use-case because of the hp regen thing