-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Labels
API BreakingBreaking ChangesBreaking Changespriority: mediumMedium priorityMedium prioritytype: maint: styleStyleStyle
Description
I think some of the matter_options parameters should be in simulation_options, since they don’t change the physical model that is used in the simulation. For example: MINIMIZE_MEMORY, USE_FFTW_WISDOM, USE_INTERPOLATION_TABLES, KEEP_3D_VELOCITIES.
I also think that PHOTONCONS_CALIBRATION_END (now in astro_params) should go into simulation_options . Also R_BUBBLE_MAX , R_BUBBLE_MIN R_MAX_TS, N_STEP_TS, and MAX_DVDR should go into simulation_options , or at least astro_options, in my opinion.
This is of course an API change, so this will have to wait for v5.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
API BreakingBreaking ChangesBreaking Changespriority: mediumMedium priorityMedium prioritytype: maint: styleStyleStyle