test: add coverage for inactive user login and duplicate collaboration validation

Author: immerSIR

Mapapi/tests/test_additional_views_coverage_8.py

@@ -65,6 +65,27 @@ def test_login_missing_credentials(self):
         response = self.client.post(self.url, data, format='json')
 
         self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+    
+    def test_login_inactive_user(self):
+        """Test login with an inactive user"""
+        # Create an inactive user
+        inactive_user = User.objects.create_user(
+            email='inactive@example.com',
+            password='testpass123',
+            first_name='Inactive',
+            last_name='User',
+            is_active=False
+        )
+        
+        data = {
+            'email': 'inactive@example.com',
+            'password': 'testpass123'
+        }
+        
+        response = self.client.post(self.url, data, format='json')
+        
+        # Should return 401 Unauthorized for inactive users
+        self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)
 
 
 @patch.object(EmailMultiAlternatives, 'send')

Mapapi/tests/test_serializer_missing_coverage.py

@@ -116,16 +116,30 @@ def test_save(self):
 
 class CollaborationSerializerTests(TestCase):
     def setUp(self):
+        # Create the user who will be the incident taker
+        self.incident_taker = User.objects.create_user(
+            email='taker@example.com',
+            password='testpass123',
+            first_name='Incident',
+            last_name='Taker',
+            organisation='Test Org'
+        )
+        
+        # Create the test user who will create the collaboration
         self.user = User.objects.create_user(
             email='user@example.com',
             password='testpass123',
             first_name='Test',
-            last_name='User'
+            last_name='User',
+            organisation='User Org'
         )
+        
+        # Create an incident with the taker
         self.incident = Incident.objects.create(
             title='Test Incident',
             zone='Test Zone',
-            user_id=self.user
+            user_id=self.incident_taker,
+            taken_by=self.incident_taker
         )
 
     def test_validate_end_date_in_past(self):
@@ -182,6 +196,33 @@ def test_validate_duplicate_collaboration(self):
 
         # Check that the error message is correct
         self.assertIn('La date de fin doit être dans le futur', str(context.exception))
+    
+    def test_validate_duplicate_collaboration(self):
+        """Test CollaborationSerializer.validate() with duplicate collaboration"""
+        # First create a collaboration
+        future_date = timezone.now().date() + timedelta(days=7)
+        data = {
+            'incident': self.incident.id,
+            'user': self.user.id,
+            'end_date': future_date,
+            'status': 'pending'
+        }
+        serializer = CollaborationSerializer(data=data)
+        self.assertTrue(serializer.is_valid())
+        collaboration = serializer.save()
+        
+        # Try to create another collaboration with the same user and incident
+        duplicate_serializer = CollaborationSerializer(data={
+            'incident': self.incident.id,
+            'user': self.user.id,
+            'end_date': future_date + timedelta(days=1),
+            'status': 'pending'
+        })
+        
+        self.assertFalse(duplicate_serializer.is_valid())
+        self.assertIn('non_field_errors', duplicate_serializer.errors)
+        self.assertIn('Une collaboration existe déjà pour cet utilisateur sur cet incident', 
+                     str(duplicate_serializer.errors['non_field_errors']))
 
 
 class ColaborationSerializerTests(TestCase):