From c3008561a58c3d02f2710c13df4831d018f0d3b9 Mon Sep 17 00:00:00 2001 From: kevin Date: Thu, 12 Dec 2024 09:59:56 -0500 Subject: [PATCH 1/2] npm ci ws and root --- .github/workflows/ci.yml | 4 +++- .nvmrc | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9d8d373..6e93bdd 100755 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,8 +24,10 @@ jobs: echo NPM Version npm --version echo - - name: Install NPM packages + - name: Install NPM packages (workspace) run: npm ci -ws + - name: Install NPM packages (root) + run: npm ci - name: Build API Types Package run: | echo Building... diff --git a/.nvmrc b/.nvmrc index eb800ed..93d866f 100755 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v18.19.0 +v18.20.5 From 0f6c82c8a401911cbd6d9f95b7eb4fee8ae57d45 Mon Sep 17 00:00:00 2001 From: kevin Date: Thu, 12 Dec 2024 12:19:56 -0500 Subject: [PATCH 2/2] fix for project picker with 3 or more items styling issue --- .../molecules/menus/ProjectPickerMenu.module.css | 5 +++++ .../src/components/molecules/menus/ProjectPickerMenu.tsx | 8 +++++--- .../components/organisms/panels/BottomPanel.module.css | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/packages/shared/src/components/molecules/menus/ProjectPickerMenu.module.css b/packages/shared/src/components/molecules/menus/ProjectPickerMenu.module.css index caae1da..5c7e111 100755 --- a/packages/shared/src/components/molecules/menus/ProjectPickerMenu.module.css +++ b/packages/shared/src/components/molecules/menus/ProjectPickerMenu.module.css @@ -1,3 +1,8 @@ .projectPickerMenu { width: 13rem; } + +.projectPickerMenuContainer { + position: absolute; + bottom: 0; +} diff --git a/packages/shared/src/components/molecules/menus/ProjectPickerMenu.tsx b/packages/shared/src/components/molecules/menus/ProjectPickerMenu.tsx index 7a8bf4c..bebd7cd 100755 --- a/packages/shared/src/components/molecules/menus/ProjectPickerMenu.tsx +++ b/packages/shared/src/components/molecules/menus/ProjectPickerMenu.tsx @@ -51,9 +51,11 @@ export const InnerProjectPickerMenu: React.FC = (pr }); const className = buildClassName(css.projectPickerMenu, props.className); return ( - - {buttons} - +
+ + {buttons} + +
); }; diff --git a/packages/shared/src/components/organisms/panels/BottomPanel.module.css b/packages/shared/src/components/organisms/panels/BottomPanel.module.css index 1206b3c..1492dc5 100755 --- a/packages/shared/src/components/organisms/panels/BottomPanel.module.css +++ b/packages/shared/src/components/organisms/panels/BottomPanel.module.css @@ -34,5 +34,5 @@ .projectPickerMenu { position: relative; left: -2.15rem; - bottom: 5.9rem; + bottom: 2rem; }