Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global fallback for missing calls to Skip.If() #27

Closed
thomaseyde opened this issue Sep 2, 2022 · 5 comments
Closed

Global fallback for missing calls to Skip.If() #27

thomaseyde opened this issue Sep 2, 2022 · 5 comments

Comments

@thomaseyde
Copy link

Would it be possible to create a global fallback for missing calls to Skip.If(...)?

@AArnott
Copy link
Owner

AArnott commented Sep 4, 2022

What is a 'global fallback'?

@thomaseyde
Copy link
Author

thomaseyde commented Sep 4, 2022 via email

@AArnott
Copy link
Owner

AArnott commented Sep 4, 2022

I'm afraid I'm still not understanding. Can you provide an example?

From the test extension's perspective, we have 0 insight into whether the test method may or may not execute a Skip.If() call before the test method is executed. And if the test method executes and Skip is never called, we can't tell that either. And even if we could tell, it's perfectly valid for a branch in the test to have skipped the call to Skip.If. What would this 'default action' do anyway?

@thomaseyde
Copy link
Author

thomaseyde commented Sep 5, 2022 via email

@AArnott
Copy link
Owner

AArnott commented Sep 5, 2022

Sorry. That would be a significant breaking change, and force a bunch of users' tests to put in a stub Skip.If call just to get their tests working again, that were already appropriately skipping but using other mechanisms.

@AArnott AArnott closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants