Align smoothstep edge cases with OSL (#1985)

ld-kerley · web-flow · commit 81e3e24f7f99 · 2024-09-05T16:34:43.000-07:00
Following a conversation on ASWF slack this PR was posted to OSL refining the edge cases for `smoothstep()`. AcademySoftwareFoundation/OpenShadingLanguage#1851 This PR aligns the GLSL/MSL code with this change.
diff --git a/libraries/stdlib/genglsl/mx_smoothstep_float.glsl b/libraries/stdlib/genglsl/mx_smoothstep_float.glsl
@@ -1,9 +1,9 @@
 void mx_smoothstep_float(float val, float low, float high, out float result)
 {
-    if (val <= low)
-        result = 0.0;
-    else if (val >= high)
+    if (val >= high)
         result = 1.0;
+    else if (val <= low)
+        result = 0.0;
     else
         result = smoothstep(low, high, val);
 }

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,9 @@`
`1`	`1`	`void mx_smoothstep_float(float val, float low, float high, out float result)`
`2`	`2`	`{`
`3`		`- if (val <= low)`
`4`		`- result = 0.0;`
`5`		`- else if (val >= high)`
	`3`	`+ if (val >= high)`
`6`	`4`	`result = 1.0;`
	`5`	`+ else if (val <= low)`
	`6`	`+ result = 0.0;`
`7`	`7`	`else`
`8`	`8`	`result = smoothstep(low, high, val);`
`9`	`9`	`}`