Activate gnat check Implicit_IN_Mode_Parameters rule.

Fix all corresponding violations.
Some others minor style fixes.

Author: TurboGit

aws.checks

@@ -3,9 +3,9 @@
 +RRaising_External_Exceptions
 +RName_Clashes
 +RGOTO_Statements
++RImplicit_IN_Mode_Parameters
 --  ******* to be activated ******************************************
 -- +RExceptions_As_Control_Flow
--- +RImplicit_IN_Mode_Parameters
 -- +RImplicit_SMALL_For_Fixed_Point_Types
 -- +RNon_Qualified_Aggregates
 -- +ROTHERS_In_Aggregates

config/aws-net-std__gnat.adb

@@ -73,7 +73,7 @@ package body AWS.Net.Std is
    --  Raise and log exception Socket_Error with E's message and a reference to
    --  the routine name.
 
-   procedure Raise_Socket_Error (Error : in Integer; Socket : Socket_Type);
+   procedure Raise_Socket_Error (Error : in Integer; Socket : in Socket_Type);
    pragma No_Return (Raise_Socket_Error);
 
    function Error_Message (Error : in Integer) return String;
@@ -222,13 +222,13 @@ package body AWS.Net.Std is
             Events : constant Event_Set
               := Net.Wait (Socket, (Output => True, Input => False));
 
-            procedure Raise_Error (Errno : Integer);
+            procedure Raise_Error (Errno : in Integer);
 
             -----------------
             -- Raise_Error --
             -----------------
 
-            procedure Raise_Error (Errno : Integer) is
+            procedure Raise_Error (Errno : in Integer) is
                Msg : constant String := Error_Message (Errno);
             begin
                Log.Error (Socket, Msg);

config/ssl-thin__openssl.ads

@@ -2,8 +2,7 @@
 --                            Secure Sockets Layer                          --
 --                         Binding to OpenSSL library                       --
 --                                                                          --
---                         Copyright (C) 2000-2006                          --
---                                 AdaCore                                  --
+--                     Copyright (C) 2000-2008, AdaCore                     --
 --                                                                          --
 --  This library is free software; you can redistribute it and/or modify    --
 --  it under the terms of the GNU General Public License as published by    --
@@ -78,7 +77,7 @@ package SSL.Thin is
       References   : int;
       Num_Read     : unsigned_long;
       Num_Write    : unsigned_long;
-      --  CRYPTO_EX_DATA ex_data; -- Do not need to translete it.
+      --  CRYPTO_EX_DATA ex_data; -- Do not need to translete it
    end record;
 
    subtype SSL_Method is Pointer;
@@ -265,13 +264,15 @@ package SSL.Thin is
 
    function  CRYPTO_num_locks return Natural;
 
-   procedure CRYPTO_set_id_callback (Id_Function : Pointer);
-   procedure CRYPTO_set_locking_callback (Locking_Function : Pointer);
+   procedure CRYPTO_set_id_callback (Id_Function : in Pointer);
+   procedure CRYPTO_set_locking_callback (Locking_Function : in Pointer);
    function  CRYPTO_get_locking_callback return Pointer;
 
-   procedure CRYPTO_set_dynlock_create_callback  (Create_Function : Pointer);
-   procedure CRYPTO_set_dynlock_lock_callback    (Lock_Function : Pointer);
-   procedure CRYPTO_set_dynlock_destroy_callback (Destroy_Function : Pointer);
+   procedure CRYPTO_set_dynlock_create_callback
+     (Create_Function : in Pointer);
+   procedure CRYPTO_set_dynlock_lock_callback    (Lock_Function : in Pointer);
+   procedure CRYPTO_set_dynlock_destroy_callback
+     (Destroy_Function : in Pointer);
 
    function CRYPTO_get_dynlock_create_callback  return Pointer;
    function CRYPTO_get_dynlock_lock_callback    return Pointer;
@@ -346,7 +347,7 @@ package SSL.Thin is
 
    function SSL_set_fd (S : in SSL_Handle; Fd : in int) return int;
 
-   procedure SSL_set_bio (SSL : in SSL_Handle; RBIO, WBIO : BIO_Access);
+   procedure SSL_set_bio (SSL : in SSL_Handle; RBIO, WBIO : in BIO_Access);
 
    function SSL_get_rbio (SSL : in SSL_Handle) return BIO_Access;
    function SSL_get_wbio (SSL : in SSL_Handle) return BIO_Access;
@@ -485,12 +486,12 @@ package SSL.Thin is
    --  BIO_set_fd(b,fd,c) BIO_int_ctrl(b,BIO_C_SET_FD,c,fd)
 
    function BIO_ctrl
-     (Bp : in BIO_Access; Cmd : in int; Larg : in long; Parg : Pointer)
+     (Bp : in BIO_Access; Cmd : in int; Larg : in long; Parg : in Pointer)
       return long;
    --  BIO_pending(b) = (int)BIO_ctrl(b,BIO_CTRL_PENDING,0,NULL)
 
    procedure BIO_ctrl
-     (Bp : in BIO_Access; Cmd : in int; Larg : in long; Parg : Pointer);
+     (Bp : in BIO_Access; Cmd : in int; Larg : in long; Parg : in Pointer);
    --  BIO_get_fd(b,c) = BIO_ctrl(b,BIO_C_GET_FD,0,(char *)c)
    --  BIO_set_mem_eof_return(b,v)
    --  = BIO_ctrl(b,BIO_C_SET_BUF_MEM_EOF_RETURN,v,NULL)
@@ -505,15 +506,15 @@ package SSL.Thin is
      (bio1 : access BIO_Access; writebuf1 : in size_t;
       bio2 : access BIO_Access; writebuf2 : in size_t) return int;
 
-   function BIO_nread0 (BIO : BIO_Access; Buf : Pointer) return int;
+   function BIO_nread0 (BIO : in BIO_Access; Buf : in Pointer) return int;
    function BIO_nread
-     (BIO : BIO_Access; Buf : Pointer; Num : in int) return int;
-   --  Buf is the address of the buffer address.
+     (BIO : in BIO_Access; Buf : in Pointer; Num : in int) return int;
+   --  Buf is the address of the buffer address
 
-   function BIO_nwrite0 (BIO : BIO_Access; Buf : Pointer) return int;
+   function BIO_nwrite0 (BIO : in BIO_Access; Buf : in Pointer) return int;
    function BIO_nwrite
-     (BIO : BIO_Access; Buf : Pointer; Num : in int) return int;
-   --  Buf is the address of the buffer address.
+     (BIO : in BIO_Access; Buf : in Pointer; Num : in int) return int;
+   --  Buf is the address of the buffer address
 
    function BIO_free (BIO : in BIO_Access) return int;
    procedure BIO_free (BIO : in BIO_Access);

include/zlib-streams.adb

@@ -1,7 +1,7 @@
 ----------------------------------------------------------------
 --  ZLib for Ada thick binding.                               --
 --                                                            --
---  Copyright (C) 2002-2003 Dmitriy Anisimkov                 --
+--  Copyright (C) 2002-2008, Dmitriy Anisimkov                --
 --                                                            --
 --  Open source license information is in the zlib.ads file.  --
 ----------------------------------------------------------------
@@ -19,7 +19,7 @@ package body ZLib.Streams is
          (Stream_Element_Array, Buffer_Access);
    begin
       if Stream.Mode = Out_Stream or Stream.Mode = Duplex then
-         --  We should flush the data written by the writer.
+         --  We should flush the data written by the writer
 
          Flush (Stream, Finish);
 
@@ -116,7 +116,7 @@ package body ZLib.Streams is
    -- Is_Open --
    -------------
 
-   function Is_Open (Stream : Stream_Type) return Boolean is
+   function Is_Open (Stream : in Stream_Type) return Boolean is
    begin
       return Is_Open (Stream.Reader) or else Is_Open (Stream.Writer);
    end Is_Open;

include/zlib-streams.ads

@@ -1,7 +1,7 @@
 ----------------------------------------------------------------
 --  ZLib for Ada thick binding.                               --
 --                                                            --
---  Copyright (C) 2002-2003 Dmitriy Anisimkov                 --
+--  Copyright (C) 2002-2008, Dmitriy Anisimkov                --
 --                                                            --
 --  Open source license information is in the zlib.ads file.  --
 ----------------------------------------------------------------
@@ -34,19 +34,19 @@ package ZLib.Streams is
 
    function Read_Total_In (Stream : in Stream_Type) return Count;
    pragma Inline (Read_Total_In);
-   --  Return total number of bytes read from back stream so far.
+   --  Return total number of bytes read from back stream so far
 
    function Read_Total_Out (Stream : in Stream_Type) return Count;
    pragma Inline (Read_Total_Out);
-   --  Return total number of bytes read so far.
+   --  Return total number of bytes read so far
 
    function Write_Total_In (Stream : in Stream_Type) return Count;
    pragma Inline (Write_Total_In);
-   --  Return total number of bytes written so far.
+   --  Return total number of bytes written so far
 
    function Write_Total_Out (Stream : in Stream_Type) return Count;
    pragma Inline (Write_Total_Out);
-   --  Return total number of bytes written to the back stream.
+   --  Return total number of bytes written to the back stream
 
    procedure Create
      (Stream            :    out Stream_Type;
@@ -75,7 +75,7 @@ package ZLib.Streams is
    --  !!! When the Need_Header is False ZLib-Ada is using undocumented
    --  ZLib 1.1.4 functionality to do not create/wait for ZLib headers.
 
-   function Is_Open (Stream : Stream_Type) return Boolean;
+   function Is_Open (Stream : in Stream_Type) return Boolean;
 
    procedure Close (Stream : in out Stream_Type);
 

include/zlib-thin.adb

@@ -1,7 +1,7 @@
 ----------------------------------------------------------------
 --  ZLib for Ada thick binding.                               --
 --                                                            --
---  Copyright (C) 2002-2003 Dmitriy Anisimkov                 --
+--  Copyright (C) 2002-2008, Dmitriy Anisimkov                --
 --                                                            --
 --  Open source license information is in the zlib.ads file.  --
 ----------------------------------------------------------------
@@ -35,13 +35,12 @@ package body ZLib.Thin is
    ------------------
 
    function Deflate_Init
-     (strm       : Z_Streamp;
-      level      : Int;
-      method     : Int;
-      windowBits : Int;
-      memLevel   : Int;
-      strategy   : Int)
-      return       Int is
+     (strm       : in Z_Streamp;
+      level      : in Int;
+      method     : in Int;
+      windowBits : in Int;
+      memLevel   : in Int;
+      strategy   : in Int) return Int is
    begin
       return deflateInit2
                (strm,
@@ -58,7 +57,8 @@ package body ZLib.Thin is
    -- Inflate_Init --
    ------------------
 
-   function Inflate_Init (strm : Z_Streamp; windowBits : Int) return Int is
+   function Inflate_Init
+     (strm : in Z_Streamp; windowBits : in Int) return Int is
    begin
       return inflateInit2 (strm, windowBits, ZLIB_VERSION, Z_Stream_Size);
    end Inflate_Init;

soap/soap-generator.adb

@@ -106,10 +106,10 @@ package body SOAP.Generator is
    --  Children - a pragma for each child unit
 
    procedure With_Unit
-     (File       : Text_IO.File_Type;
-      Name       : String;
-      Elab       : Elab_Pragma := Single;
-      Use_Clause : Boolean := False);
+     (File       : in Text_IO.File_Type;
+      Name       : in String;
+      Elab       : in Elab_Pragma := Single;
+      Use_Clause : in Boolean := False);
    --  Output a with clause for unit Name, also output a use clause if
    --  Use_Clause is set. A pragma Elaborate_All is issued for this unit if
    --  Elab is set.
@@ -2722,10 +2722,10 @@ package body SOAP.Generator is
    ---------------
 
    procedure With_Unit
-     (File       : Text_IO.File_Type;
-      Name       : String;
-      Elab       : Elab_Pragma := Single;
-      Use_Clause : Boolean := False) is
+     (File       : in Text_IO.File_Type;
+      Name       : in String;
+      Elab       : in Elab_Pragma := Single;
+      Use_Clause : in Boolean := False) is
    begin
       Text_IO.Put_Line (File, "with " & Name & ';');
 

soap/soap-types.adb

@@ -757,7 +757,7 @@ package body SOAP.Types is
          -- I2D --
          ---------
 
-         function I2D (N : Natural) return Str2 is
+         function I2D (N : in Natural) return Str2 is
             V : constant String := Natural'Image (N);
          begin
             if N > 9 then

src/aws-client-http_utils.adb

@@ -1009,13 +1009,13 @@ package body AWS.Client.HTTP_Utils is
            := Ada.Characters.Handling.To_Lower
                 (Header (Answer, Messages.Content_Encoding_Token));
 
-         procedure Decode_Init (Header : ZLib.Header_Type);
+         procedure Decode_Init (Header : in ZLib.Header_Type);
 
          -----------------
          -- Decode_Init --
          -----------------
 
-         procedure Decode_Init (Header : ZLib.Header_Type) is
+         procedure Decode_Init (Header : in ZLib.Header_Type) is
             use type Utils.Stream_Element_Array_Access;
          begin
             ZLib.Inflate_Init (Connection.Decode_Filter, Header => Header);

src/aws-config.adb

@@ -55,7 +55,7 @@ package body AWS.Config is
    -- Admin_URI --
    ---------------
 
-   function Admin_URI (O : Object) return String is
+   function Admin_URI (O : in Object) return String is
    begin
       return To_String (O.P (Admin_URI).Str_Value);
    end Admin_URI;
@@ -64,7 +64,7 @@ package body AWS.Config is
    -- Case_Sensitive_Parameters --
    -------------------------------
 
-   function Case_Sensitive_Parameters (O : Object) return Boolean is
+   function Case_Sensitive_Parameters (O : in Object) return Boolean is
    begin
       return O.P (Case_Sensitive_Parameters).Bool_Value;
    end Case_Sensitive_Parameters;