fix(shellterm): resolve session workspace path for terminals opened f… - #3086
Open
anmol0b wants to merge 2 commits into
Open
fix(shellterm): resolve session workspace path for terminals opened f…#3086anmol0b wants to merge 2 commits into
anmol0b wants to merge 2 commits into
Conversation
…rom a session scope assertion.
anmol0b
force-pushed
the
fix/shellterm-session-workspace
branch
from
July 25, 2026 01:48
23015b7 to
e5753e1
Compare
Collaborator
|
Thanks for contributing to Agent Orchestrator. This PR is being picked up by the current external contributor on-call pair: If someone is already working on this, please continue as usual. For faster context or live questions, you can also join the AO Discord. Join the session here: Come by if you want to see what is being built, ask questions, or just hang around with the community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds session-scoped workspace resolution to OpenShellTerminal, so a standalone terminal opened while viewing an agent session starts in that session's worktree instead of always defaulting to the project's main root.
Why
Fixes #3061. A terminal opened from a session view looked co-located with the active agent, but ran against a different checkout/branch — the project root, not the session's worktree — making it easy to inspect, build, or edit the wrong tree.
How
shortcut share the same useOpenShellTerminalmutation, so both pick up the fix identically without separate handling.Testing
Backend (backend/):

New/updated backend tests: TestOpenShellTerminalStartsInSessionWorkspaceNotProjectRoot, TestOpenShellTerminalFallsBackToProjectRootWhenSessionHasNoWorkspaceYet, TestOpenShellTerminalReturnsNotFoundForUnknownSession, TestOpenShellTerminalWithoutSessionIgnoresSessionLocator, and TestOpenShellTerminalScopesToSession (updated to use a populated session locator).
Frontend (frontend/):
New test: "scopes the terminal to the session in scope", alongside the existing "scopes the terminal to the project in scope".
Checklist
main(or continuing an existing PR branch)go, frontend, etc.)