add editor config and eslint rules

Author: alexandru-calinoiu

.editorconfig

@@ -0,0 +1,13 @@
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.{sh,markdown, md}]
+indent_size = 4
+trim_trailing_whitespace = false

.eslintrc

@@ -0,0 +1,118 @@
+{
+  "rules": {
+    "no-console": 2,
+    "no-alert": 2,
+    "no-debugger": 2,
+    "comma-dangle": [2, "never"],
+    "quotes": [2, "single", "avoid-escape"],
+    "no-unused-vars": [2, {"args": "after-used", "argsIgnorePattern": "^_"}],
+    "no-empty": 2,
+    "no-cond-assign": [2, "always"],
+    "no-constant-condition": 2,
+    "no-dupe-keys": 2,
+    "no-extra-parens": 2,
+    "no-extra-semi": 2,
+    "no-inner-declarations": 2,
+    "no-irregular-whitespace": 2,
+    "no-negated-in-lhs": 2,
+    "no-sparse-arrays": 2,
+    "no-unexpected-multiline": 2,
+    "no-unreachable": 2,
+    "valid-typeof": 2,
+    "block-scoped-var": 2,
+    "consistent-return": 2,
+    "curly": 2,
+    "dot-location": [2, "property"],
+    "eqeqeq": [2, "smart"],
+    "no-else-return": 2,
+    "no-implicit-coercion": [2, {"boolean": true, "number": true, "string": true}],
+    "no-lone-blocks": 2,
+    "no-magic-numbers": [2, {"ignore": [8080]}],
+    "no-loop-func": 2,
+    "no-multi-spaces": 2,
+    "no-multi-str": 2,
+    "no-new-wrappers": 2,
+    "no-new": 2,
+    "no-throw-literal": 2,
+    "no-redeclare": 2,
+    "no-useless-call": 2,
+    "no-useless-concat": 2,
+    "vars-on-top": 2,
+    "yoda": 2,
+    "no-catch-shadow": 2,
+    "no-shadow-restricted-names": 2,
+    "no-shadow": 2,
+    "no-use-before-define": 2,
+    "array-bracket-spacing": [2, "never"],
+    "block-spacing": 2,
+    "brace-style": [2, "1tbs", { "allowSingleLine": true }],
+    "camelcase": [2, {"properties": "always"}],
+    "comma-spacing": [2, {"before": false, "after": true}],
+    "comma-style": [2, "last"],
+    "computed-property-spacing": [2, "never"],
+    "consistent-this": [2, "self"],
+    "eol-last": 2,
+    "indent": [2, 2, {"SwitchCase": 1}],
+    "key-spacing": [2, {"beforeColon": false, "afterColon": true}],
+    "new-cap": 2,
+    "new-parens": 2,
+    "newline-after-var": [2, "always"],
+    "no-lonely-if": 2,
+    "no-multiple-empty-lines": [2, {"max": 1, "maxEOF": 1}],
+    "no-negated-condition": 2,
+    "no-nested-ternary": 2,
+    "no-spaced-func": 2,
+    "no-trailing-spaces": 2,
+    "no-unneeded-ternary": 2,
+    "object-curly-spacing": [2, "never"],
+    "operator-linebreak": [2, "before"],
+    "padded-blocks": [2, "never"],
+    "quote-props": [2, "consistent-as-needed"],
+    "semi-spacing": 2,
+    "space-after-keywords": 2,
+    "space-before-blocks": 2,
+    "space-before-function-paren": [2, { "anonymous": "always", "named": "never" }],
+    "space-before-keywords": [2, "always"],
+    "space-in-parens": [2, "never"],
+    "space-infix-ops": 2,
+    "space-return-throw-case": 2,
+    "space-unary-ops": 2,
+    "linebreak-style": [2, "unix"],
+    "semi": [2, "always"],
+    "backbone/initialize-on-top": [2, {
+      "View": ["width", "tagName", "className", "attributes", "template", "alwaysSuppressHighlightErrors", "subViews", "events", "constructor"],
+      "Model": ["defaults"],
+      "Collection": ["model"]
+    }],
+    "backbone/events-on-top": [2, ["tagName", "className", "attributes", "template", "alwaysSuppressHighlightErrors", "subViews"]]
+  },
+  "env": {
+    "browser": true,
+    "jquery": true,
+    "jasmine": true
+  },
+  "plugins": [
+    "backbone"
+  ],
+  "globals": {
+    "Backbone": true,
+    "_": true,
+    "requirejs": true,
+    "require": true,  
+    "define": true,
+    "ejs": true,
+    "module": true,
+    "process": true
+  },
+  "settings": {
+    "backbone": {
+      "Collection": [
+      ],
+      "Model": [
+      ],
+      "View": [
+      ]
+    }
+  },
+  "extends": "eslint:recommended"
+}

app/js/app.js

@@ -2,10 +2,10 @@ define([
   'backbone',
   'router'
 ], function (Backbone, Router) {
-  return function() {
+  return function () {
     this.initialize = function () {
       Router.initialize();
       Backbone.history.start();
-    }
+    };
   };
 });

app/js/main.js

@@ -19,6 +19,6 @@ requirejs.config({
 requirejs([
   'app',
   'ejs'
-], function(App) {
+], function (App) {
   new App().initialize();
 });

app/js/router.js

@@ -3,20 +3,21 @@ define([
   'views/app_view'
 ], function (Backbone, AppView) {
   var Router = Backbone.Router.extend({
-      routes: {
-        "(?:params)": "index"
-      },
-
-      index: function () {
-        var appView = new AppView();
-        appView.render();
-      }
+    routes: {
+      '(?:params)': 'index'
     },
+
+    index: function () {
+      var appView = new AppView();
+
+      appView.render();
+    }
+  },
     {
       initialize: function () {
         return new Router();
       }
     });
 
   return Router;
-});
+});

app/js/views/app_view.js

@@ -4,17 +4,18 @@ define([
   'text!templates/app_view.ejs'
 ], function ($, Backbone, indexTemplate) {
   return Backbone.View.extend({
-    el: $('#todo-app'),
+    el: this.$('#todo-app'),
 
     currentDate: function () {
       return new Date();
     },
 
     render: function () {
       var compiledTemplate = ejs.render(indexTemplate, {view: this, model: this.model}, {});
+
       this.$el.empty();
       this.$el.append(compiledTemplate);
-      return this
+      return this;
     }
   });
 });

server.js

@@ -1,15 +1,14 @@
 var connect = require('connect'),
   http = require('http'),
   app;
+var port = process.env.PORT || 8080;
 
 app = connect()
   .use(connect.static('app'))
   .use('/js/lib/', connect.static('node_modules/requirejs/'))
   .use('/js/templates/', connect.static('app/js/templates/'))
   .use('/node_modules', connect.static('node_modules'));
 
-var port = process.env.PORT || 8080;
-
-http.createServer(app).listen(port, function() {
-  console.log('Running on http://localhost:' + port);
+http.createServer(app).listen(port, function () {
+  console.log('Running on http://localhost:' + port);   // eslint-disable-line no-console
 });

spec/js/router_spec.js

@@ -14,8 +14,8 @@ define([
   describe('routes', function () {
     beforeEach(function () {
       subject = function () {
-        return instance.routes
-      }
+        return instance.routes;
+      };
     });
 
     it('has a index route', function () {
@@ -25,11 +25,11 @@ define([
 
   describe('navigate to empty route', function () {
     beforeEach(function () {
-      Backbone.history.start({silent:true, pushState:true});
+      Backbone.history.start({silent: true, pushState: true});
 
       subject = function () {
-        instance.navigate('', true)
-      }
+        instance.navigate('', true);
+      };
     });
 
     it('calls render on the index view', function () {
@@ -38,6 +38,6 @@ define([
       subject();
 
       expect(renderSpy).toHaveBeenCalled();
-    })
-  })
+    });
+  });
 });

spec/js/views/app_view_spec.js

@@ -8,21 +8,21 @@ define([
     instance = new Index({el: $('body')});
     subject = function () {
       return instance;
-    }
+    };
   });
 
   describe('render', function () {
-    it ('will get rendered', function () {
+    it('will get rendered', function () {
       subject().render();
       expect(subject().$el.text()).toEqual(jasmine.stringMatching(/The current date is:/));
-    })
+    });
   });
 
   describe('currentDate', function () {
     beforeEach(function () {
       subject = function () {
         return instance.currentDate();
-      }
+      };
     });
 
     it('returns a date', function () {

spec/karma.conf.js

@@ -1,7 +1,7 @@
 // Karma configuration
 // Generated on Sun Apr 05 2015 22:10:43 GMT+0300 (EEST)
 
-module.exports = function(config) {
+module.exports = function (config) {
   config.set({
 
     // base path, that will be used to resolve files and exclude
@@ -36,36 +36,29 @@ module.exports = function(config) {
       'spec/test_main.js'
     ],
 
-
     // list of files to exclude
     exclude: [
       'app/js/main.js',
       'spec/*.conf.js'
     ],
 
-
     // test results reporter to use
     // possible values: 'dots', 'progress', 'junit', 'growl', 'coverage'
     reporters: ['dots', 'coverage'], // to use coverage, replace `html` with `coverage`
 
-
     // web server port
     port: 9876,
 
-
     // enable / disable colors in the output (reporters and logs)
     colors: true,
 
-
     // level of logging
     // possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG
     logLevel: config.LOG_INFO,
 
-
     // enable / disable watching file and executing tests whenever any file changes
     autoWatch: true,
 
-
     // Start these browsers, currently available:
     // - Chrome
     // - ChromeCanary
@@ -76,11 +69,9 @@ module.exports = function(config) {
     // - IE (only Windows; has to be installed with `npm install karma-ie-launcher`)
     browsers: ['PhantomJS'],
 
-
     // If browser does not capture in given timeout [ms], kill it
     captureTimeout: 60000,
 
-
     // Continuous Integration mode
     // if true, it capture browsers, run tests and exit
     singleRun: false,
@@ -90,8 +81,8 @@ module.exports = function(config) {
     },
 
     coverageReporter: {
-      type : 'html',
-      dir : 'spec/coverage'
+      type: 'html',
+      dir: 'spec/coverage'
     }
   });
 };

spec/test_main.js

@@ -1,11 +1,11 @@
 var allTestFiles = [];
 var TEST_REGEXP = /spec\.js$/;
 
-var pathToModule = function(path) {
+var pathToModule = function (path) {
   return path.replace(/^\/base\//, '../../').replace(/\.js$/, '');
 };
 
-Object.keys(window.__karma__.files).forEach(function(file) {
+Object.keys(window.__karma__.files).forEach(function (file) {
   if (TEST_REGEXP.test(file)) {
     // Normalize paths to RequireJS module names.
     allTestFiles.push(pathToModule(file));
@@ -36,4 +36,4 @@ require.config({
 
   // we have to kickoff jasmine, as it is asynchronous
   callback: window.__karma__.start
-});
+});