Orientation-aware key glyphs (tidyverse#4757)

Fixes tidyverse#4732

Author: mjskay

NAMESPACE

@@ -305,6 +305,7 @@ export(draw_key_boxplot)
 export(draw_key_crossbar)
 export(draw_key_dotplot)
 export(draw_key_label)
+export(draw_key_linerange)
 export(draw_key_path)
 export(draw_key_point)
 export(draw_key_pointrange)

NEWS.md

@@ -70,6 +70,9 @@ precedence between `bins` and `binwidth`. (@eliocamp, #4651)
 * Dots in `geom_dotplot()` are now correctly aligned to the baseline when
   `stackratio != 1` and `stackdir != "up"` (@mjskay, #4614)
 
+* Key glyphs for `geom_boxplot()`, `geom_crossbar()`, `geom_pointrange()`, and
+  `geom_linerange()` are now orientation-aware (@mjskay, #4732)
+
 # ggplot2 3.3.5
 This is a very small release focusing on fixing a couple of untenable issues 
 that surfaced with the 3.3.4 release

R/geom-linerange.r

@@ -93,7 +93,7 @@ geom_linerange <- function(mapping = NULL, data = NULL,
 GeomLinerange <- ggproto("GeomLinerange", Geom,
   default_aes = aes(colour = "black", size = 0.5, linetype = 1, alpha = NA),
 
-  draw_key = draw_key_vpath,
+  draw_key = draw_key_linerange,
 
   required_aes = c("x|y", "ymin|xmin", "ymax|xmax"),
 

R/legend-draw.r

@@ -106,7 +106,8 @@ draw_key_boxplot <- function(data, params, size) {
       lty = data$linetype %||% 1,
       lineend = params$lineend %||% "butt",
       linejoin = params$linejoin %||% "mitre"
-    )
+    ),
+    vp = if (isTRUE(params$flipped_aes)) viewport(angle = -90)
   )
 }
 
@@ -123,7 +124,8 @@ draw_key_crossbar <- function(data, params, size) {
       lty = data$linetype %||% 1,
       lineend = params$lineend %||% "butt",
       linejoin = params$linejoin %||% "mitre"
-    )
+    ),
+    vp = if (isTRUE(params$flipped_aes)) viewport(angle = -90)
   )
 }
 
@@ -177,11 +179,21 @@ draw_key_dotplot <- function(data, params, size) {
   )
 }
 
+#' @export
+#' @rdname draw_key
+draw_key_linerange <- function(data, params, size) {
+  if (isTRUE(params$flipped_aes)) {
+    draw_key_path(data, params, size)
+  } else {
+    draw_key_vpath(data, params, size)
+  }
+}
+
 #' @export
 #' @rdname draw_key
 draw_key_pointrange <- function(data, params, size) {
   grobTree(
-    draw_key_vpath(data, params, size),
+    draw_key_linerange(data, params, size),
     draw_key_point(transform(data, size = (data$size %||% 1.5) * 4), params)
   )
 }