Skip to content

Commit acaa98e

Browse files
thomasp85thomasp85
authored
Merge pull request tidyverse#4525 from tidyverse/v3.3.5-rc
Quick patch release to fix issues surfaced in 3.3.4
2 parents 389b864 + e94c9fe commit acaa98e

12 files changed

+496
-1136
lines changed

‎DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Package: ggplot2
2-
Version: 3.3.4.9000
2+
Version: 3.3.5.9000
33
Title: Create Elegant Data Visualisations Using the Grammar of Graphics
44
Description: A system for 'declaratively' creating graphics,
55
based on "The Grammar of Graphics". You provide the data, tell 'ggplot2'

‎NEWS.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,19 @@
11
# ggplot2 (development version)
22

3+
# ggplot2 3.3.5
4+
This is a very small release focusing on fixing a couple of untenable issues
5+
that surfaced with the 3.3.4 release
6+
7+
* Revert changes made in #4434 (apply transform to intercept in `geom_abline()`)
8+
as it introduced undesirable issues far worse than the bug it fixed
9+
(@thomasp85, #4514)
10+
* Fixes an issue in `ggsave()` when producing emf/wmf files (@yutannihilation,
11+
#4521)
12+
* Warn when grDevices specific arguments are passed to ragg devices (@thomasp85,
13+
#4524)
14+
* Fix an issue where `coord_sf()` was reporting that it is non-linear
15+
even when data is provided in projected coordinates (@clauswilke, #4527)
16+
317
# ggplot2 3.3.4
418
This is a larger patch release fixing a huge number of bugs and introduces a
519
small selection of feature refinements.

‎R/coord-sf.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ CoordSf <- ggproto("CoordSf", CoordCartesian,
2222

2323
params <- list(
2424
crs = crs,
25-
default_crs = self$default_crs %||% crs
25+
default_crs = self$default_crs
2626
)
2727
self$params <- params
2828

‎R/ggplot-global.R

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ ggplot_global$element_tree <- list()
2020
"colour", "fg", "fill", "group", "hjust", "label", "linetype", "lower",
2121
"lty", "lwd", "max", "middle", "min", "pch", "radius", "sample", "shape",
2222
"size", "srt", "upper", "vjust", "weight", "width", "x", "xend", "xmax",
23-
"xmin", "xintercept", "y", "yend", "ymax", "ymin", "yintercept", "z",
24-
"intercept"
23+
"xmin", "xintercept", "y", "yend", "ymax", "ymin", "yintercept", "z"
2524
)
2625

2726
ggplot_global$all_aesthetics <- .all_aesthetics
@@ -49,7 +48,7 @@ ggplot_global$base_to_ggplot <- .base_to_ggplot
4948
# These two vectors must match in length and position of symmetrical aesthetics
5049
# xintercept2 is a filler to match to the intercept aesthetic in geom_abline
5150
ggplot_global$x_aes <- c("x", "xmin", "xmax", "xend", "xintercept",
52-
"xmin_final", "xmax_final", "xlower", "xmiddle", "xupper", "x0", "xintercept2")
51+
"xmin_final", "xmax_final", "xlower", "xmiddle", "xupper", "x0")
5352

5453
ggplot_global$y_aes <- c("y", "ymin", "ymax", "yend", "yintercept",
55-
"ymin_final", "ymax_final", "lower", "middle", "upper", "y0", "intercept")
54+
"ymin_final", "ymax_final", "lower", "middle", "upper", "y0")

‎R/save.r

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,9 @@ plot_dev <- function(device, filename = NULL, dpi = 300) {
178178
paper = "special")
179179
}
180180
if (requireNamespace('ragg', quietly = TRUE)) {
181-
png_dev <- ragg::agg_png
182-
jpeg_dev <- ragg::agg_jpeg
183-
tiff_dev <- ragg::agg_tiff
181+
png_dev <- absorb_grdevice_args(ragg::agg_png)
182+
jpeg_dev <- absorb_grdevice_args(ragg::agg_jpeg)
183+
tiff_dev <- absorb_grdevice_args(ragg::agg_tiff)
184184
} else {
185185
png_dev <- grDevices::png
186186
jpeg_dev <- grDevices::jpeg
@@ -192,8 +192,9 @@ plot_dev <- function(device, filename = NULL, dpi = 300) {
192192
tex = function(filename, ...) grDevices::pictex(file = filename, ...),
193193
pdf = function(filename, ..., version = "1.4") grDevices::pdf(file = filename, ..., version = version),
194194
svg = function(filename, ...) svglite::svglite(file = filename, ...),
195-
emf = function(...) grDevices::win.metafile(...),
196-
wmf = function(...) grDevices::win.metafile(...),
195+
# win.metafile() doesn't have `bg` arg so we need to absorb it before passing `...`
196+
emf = function(..., bg = NULL) grDevices::win.metafile(...),
197+
wmf = function(..., bg = NULL) grDevices::win.metafile(...),
197198
png = function(...) png_dev(..., res = dpi, units = "in"),
198199
jpg = function(...) jpeg_dev(..., res = dpi, units = "in"),
199200
jpeg = function(...) jpeg_dev(..., res = dpi, units = "in"),
@@ -220,3 +221,12 @@ plot_dev <- function(device, filename = NULL, dpi = 300) {
220221
grid.draw.ggplot <- function(x, recording = TRUE) {
221222
print(x)
222223
}
224+
225+
absorb_grdevice_args <- function(f) {
226+
function(..., type, antialias) {
227+
if (!missing(type) || !missing(antialias)) {
228+
warn("Using ragg device as default. Ignoring `type` and `antialias` arguments")
229+
}
230+
f(...)
231+
}
232+
}

‎README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,15 @@ documentation pages. Currently, there are three good places to start:
8484
get you up to speed with the essentials of ggplot2 as quickly as
8585
possible.
8686

87-
2. If you’d like to follow a webinar, try [Plotting Anything with
87+
2. If you’d like to take an online course, try [Data Visualization in R
88+
With
89+
ggplot2](https://learning.oreilly.com/videos/data-visualization-in/9781491963661/)
90+
by Kara Woo.
91+
92+
3. If you’d like to follow a webinar, try [Plotting Anything with
8893
ggplot2](https://youtu.be/h29g21z0a68) by Thomas Lin Pedersen.
8994

90-
3. If you want to dive into making common graphics as quickly as
95+
4. If you want to dive into making common graphics as quickly as
9196
possible, I recommend [The R Graphics
9297
Cookbook](https://r-graphics.org) by Winston Chang. It provides a
9398
set of recipes to solve common graphics problems.

‎cran-comments.md

Lines changed: 3 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -1,98 +1,7 @@
1-
This is mainly a patch release, though we have folded in a couple of new
2-
features. The release contains a couple of internal breaking changes which can
3-
affect packages that inspects the internals of ggplot objects. All failing
4-
reverse dependencies have been notified 3 weeks ago with information about what
5-
needs to be fixed and how. Most of these have already published a fix or is in
6-
the process of doing so.
1+
This is a very quick patch release addressing some unforeseen issues with the
2+
latest release. It does not contain any breaking changes and no changes to worse
3+
in the reverse dependencies was detected.
74

85
## R CMD check results
96

107
0 errors | 0 warnings | 0 note
11-
12-
## revdepcheck results
13-
14-
We checked 3149 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
15-
16-
* We saw 11 new problems
17-
* We failed to check 39 packages
18-
19-
Issues with CRAN packages are summarised below.
20-
21-
### New problems
22-
(This reports the first line of each new failure)
23-
24-
* bayesAB
25-
checking tests ... ERROR
26-
27-
* BayesianReasoning
28-
checking tests ... ERROR
29-
30-
* cvms
31-
checking tests ... ERROR
32-
33-
* ezEDA
34-
checking tests ... ERROR
35-
36-
* ggseg
37-
checking examples ... ERROR
38-
checking tests ... ERROR
39-
40-
* HRM
41-
checking dependencies in R code ... NOTE
42-
43-
* plotly
44-
checking tests ... ERROR
45-
46-
* ratPASTA
47-
checking tests ... ERROR
48-
49-
* rBiasCorrection
50-
checking tests ... ERROR
51-
52-
* tricolore
53-
checking examples ... ERROR
54-
55-
* xpose
56-
checking tests ... ERROR
57-
58-
### Failed to check
59-
60-
* ActivePathways (NA)
61-
* apc (NA)
62-
* apisensr (NA)
63-
* backShift (NA)
64-
* bayesdfa (NA)
65-
* bayesGAM (NA)
66-
* bayesZIB (NA)
67-
* bmgarch (NA)
68-
* CausalImpact (NA)
69-
* CB2 (NA)
70-
* cbar (NA)
71-
* dfpk (NA)
72-
* diceR (NA)
73-
* GenHMM1d (NA)
74-
* ggmsa (NA)
75-
* ggtern (NA)
76-
* glmmfields (NA)
77-
* MarketMatching (NA)
78-
* mcmcabn (NA)
79-
* metagam (NA)
80-
* mlr3pipelines (NA)
81-
* OncoBayes2 (NA)
82-
* osmplotr (NA)
83-
* pcalg (NA)
84-
* penaltyLearning (NA)
85-
* phylopath (NA)
86-
* rabhit (NA)
87-
* raw (NA)
88-
* rstap (NA)
89-
* scoper (NA)
90-
* spectralAnalysis (NA)
91-
* StroupGLMM (NA)
92-
* SynthETIC (NA)
93-
* tigger (NA)
94-
* trackr (NA)
95-
* valse (NA)
96-
* vivid (NA)
97-
* wrswoR (NA)
98-
* zenplots (NA)

‎revdep/README.md

Lines changed: 52 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,58 @@
11
# Revdeps
22

3-
## Failed to check (39)
3+
## Failed to check (45)
44

5-
|package |version |error |warning |note |
6-
|:------------------------------------|:-------|:------|:-------|:----|
7-
|ActivePathways |? | | | |
8-
|apc |? | | | |
9-
|apisensr |? | | | |
10-
|backShift |? | | | |
11-
|bayesdfa |1.1.0 |1 | | |
12-
|bayesGAM |0.0.1 |1 | | |
13-
|bayesZIB |0.0.2 |1 | | |
14-
|bmgarch |1.0.0 |1 | | |
15-
|CausalImpact |? | | | |
16-
|CB2 |? | | | |
17-
|cbar |? | | | |
18-
|dfpk |3.5.1 |1 | | |
19-
|diceR |? | | | |
20-
|GenHMM1d |? | | | |
21-
|ggmsa |? | | | |
22-
|[ggtern](failures.md#ggtern) |3.3.0 |__+1__ | |1 -2 |
23-
|glmmfields |0.1.4 |1 | | |
24-
|MarketMatching |? | | | |
25-
|mcmcabn |? | | | |
26-
|metagam |? | | | |
27-
|mlr3pipelines |? | | | |
28-
|[OncoBayes2](failures.md#oncobayes2) |0.7-0 |__+1__ | |-2 |
29-
|osmplotr |? | | | |
30-
|pcalg |? | | | |
31-
|penaltyLearning |? | | | |
32-
|phylopath |? | | | |
33-
|rabhit |? | | | |
34-
|raw |? | | | |
35-
|rstap |1.0.3 |1 | | |
36-
|scoper |? | | | |
37-
|spectralAnalysis |? | | | |
38-
|StroupGLMM |? | | | |
39-
|SynthETIC |? | | | |
40-
|tigger |? | | | |
41-
|trackr |? | | | |
42-
|valse |0.1-0 |1 | | |
43-
|vivid |? | | | |
44-
|wrswoR |? | | | |
45-
|zenplots |? | | | |
5+
|package |version |error |warning |note |
6+
|:----------------|:-------|:-----|:-------|:----|
7+
|ActivePathways |? | | | |
8+
|apc |? | | | |
9+
|apisensr |? | | | |
10+
|backShift |? | | | |
11+
|bayesdfa |1.1.0 |1 | | |
12+
|bayesZIB |0.0.2 |1 | | |
13+
|NA |? | | | |
14+
|NA |? | | | |
15+
|btergm |1.9.13 |1 | | |
16+
|CausalImpact |? | | | |
17+
|CB2 |? | | | |
18+
|cbar |? | | | |
19+
|NA |? | | | |
20+
|dfpk |3.5.1 |1 | | |
21+
|diceR |? | | | |
22+
|GenHMM1d |? | | | |
23+
|ggmsa |? | | | |
24+
|ggtern |3.3.0 |1 | |1 |
25+
|glmmfields |0.1.4 |1 | | |
26+
|NA |? | | | |
27+
|mcmcabn |? | | | |
28+
|NA |? | | | |
29+
|metagam |? | | | |
30+
|MoMPCA |? | | | |
31+
|osmplotr |? | | | |
32+
|pcalg |? | | | |
33+
|penaltyLearning |? | | | |
34+
|phylopath |? | | | |
35+
|NA |? | | | |
36+
|rabhit |? | | | |
37+
|raw |? | | | |
38+
|rstap |1.0.3 |1 | | |
39+
|scoper |? | | | |
40+
|spectralAnalysis |? | | | |
41+
|NA |? | | | |
42+
|StroupGLMM |? | | | |
43+
|superb |? | | | |
44+
|SynthETIC |? | | | |
45+
|NA |? | | | |
46+
|tigger |? | | | |
47+
|trackr |? | | | |
48+
|valse |0.1-0 |1 | | |
49+
|vivid |? | | | |
50+
|wrswoR |? | | | |
51+
|zenplots |? | | | |
4652

47-
## New problems (11)
53+
## New problems (1)
4854

49-
|package |version |error |warning |note |
50-
|:--------------------------------------------------|:-------|:------|:-------|:------|
51-
|[bayesAB](problems.md#bayesab) |1.1.2 |__+1__ | | |
52-
|[BayesianReasoning](problems.md#bayesianreasoning) |0.3.2 |__+1__ | | |
53-
|[cvms](problems.md#cvms) |1.3.0 |__+1__ | | |
54-
|[ezEDA](problems.md#ezeda) |0.1.0 |__+1__ | | |
55-
|[ggseg](problems.md#ggseg) |1.6.3 |__+2__ | | |
56-
|[HRM](problems.md#hrm) |1.2.1 | | |__+1__ |
57-
|[plotly](problems.md#plotly) |4.9.4 |__+1__ | |1 |
58-
|[ratPASTA](problems.md#ratpasta) |0.2.1 |__+1__ | |1 |
59-
|[rBiasCorrection](problems.md#rbiascorrection) |0.3.0 |__+1__ | | |
60-
|[tricolore](problems.md#tricolore) |1.2.2 |__+1__ | | |
61-
|[xpose](problems.md#xpose) |0.4.12 |__+1__ | | |
55+
|package |version |error |warning |note |
56+
|:----------------------------------------|:---------|:-----|:-------|:------|
57+
|[rvinecopulib](problems.md#rvinecopulib) |0.5.5.1.1 |-1 | |__+1__ |
6258

0 commit comments

Comments
 (0)