Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make io_status table #153

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

make io_status table #153

wants to merge 6 commits into from

Conversation

hatobus
Copy link
Member

@hatobus hatobus commented Jul 8, 2019 •
edited by wancom
Loading

io_statusというテーブルを新たに作成し、そこをREFERENCEするようにする変更です

close #151

@hatobus hatobus changed the title make io_status table [WIP]make io_status table Jul 8, 2019
@wancom
Copy link
Member

wancom commented Jul 8, 2019 •
edited
Loading

close #151

@hatobus hatobus changed the title [WIP]make io_status table make io_status table Jul 10, 2019
@hatobus hatobus requested review from wancom and nozo-moto July 18, 2019 06:11
wancom
wancom suggested changes Jul 18, 2019
View reviewed changes
Copy link
Member

@wancom wancom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認お願いします。

cmd/db/db.go Outdated Show resolved Hide resolved
@wancom
Copy link
Member

wancom commented Jul 18, 2019

あれ？コンフリ起こしてる？

@hatobus @wancom
Update cmd/db/db.go
d41105f 
Co-Authored-By: wancom <[email protected]>
@wancom wancom self-requested a review July 19, 2019 00:21
wancom
wancom approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@wancom wancom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。
頑張ってコンフリ直してください！

@hatobus
Copy link
Member Author

hatobus commented Jul 19, 2019

このコンフリクトですが、masterの方で cmd ディレクトリが消えたために起きたもので、masterの内容をmergeすれば、コンフリクトしていたファイルがきちんとした位置に配置されコンフリクトが解消しました。

@wancom
Copy link
Member

wancom commented Jul 19, 2019

そういえばサーバのディレクトリ構成を思いっきり変えたのでその影響ですね

@wancom
Copy link
Member

wancom commented Jul 19, 2019 •
edited
Loading

マージする前にちゃんと動くか確認したいのでそれまでマージしないようにお願いします。
（すっかり忘れてた）

@hatobus
Copy link
Member Author

hatobus commented Jul 19, 2019

テストすべて通った 🎉

@wancom
Copy link
Member

wancom commented Jul 19, 2019

CIrcleCIはコンパイルとリリースがメインなのでテストしてないです。
Releaseにベータ版が上がっているのでAGDのラズパイでサービスを停止してからdistとelsystemを置き換えて再起動してください。
それで問題がなければ大丈夫です

@hatobus
Copy link
Member Author

hatobus commented Jul 19, 2019

あーなるほど、実機でテストしないとダメか

@wancom
Copy link
Member

wancom commented Jul 23, 2019

close #151

@wancom
Copy link
Member

wancom commented Jul 29, 2019

これやんなきゃ。
明日のミーティング時にやります。

@nozo-moto nozo-moto removed their request for review May 23, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wancom wancom wancom approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB見直し
2 participants
@hatobus @wancom