Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions - Initial Implementation #1341

Closed
3 tasks done
benjamin-kirkbride opened this issue Jul 6, 2023 · 3 comments · Fixed by #1349
Closed
3 tasks done

Actions - Initial Implementation #1341

benjamin-kirkbride opened this issue Jul 6, 2023 · 3 comments · Fixed by #1349

Comments

@benjamin-kirkbride
Copy link
Contributor

benjamin-kirkbride commented Jul 6, 2023

Subtask of #1342

Reqs from #1335 (comment)

Requirements:

  • actions.py: the action classes, the registry and the related functions
  • A few producers (i.e. add an action in a few plugins)
  • One consumer
@benjamin-kirkbride benjamin-kirkbride mentioned this issue Jul 6, 2023
11 tasks
@Akuli
Copy link
Owner

Akuli commented Jul 6, 2023

Here is the old actions.py that I deleted and merged with menubar a few years ago: https://github.com/Akuli/porcupine/blob/3970a8ad898108f4979f2b004bf4be0d32b2e280/porcupine/actions.py

Not sure how useful that will be. It's not very nice, but it does a similar thing to we're planning and could be better than nothing as a starting point. Or maybe it is easier to start from scratch, I don't know :)

@benjamin-kirkbride
Copy link
Contributor Author

@Akuli with db47f32 this is technically done (pending review ofc), by the requirements that were set out.

From here we could:

  • finish the menubar implementation (Actions - menubar #1343)
  • work on a different consumer (probably the command palette)
  • something else?

Thoughts?

@Akuli
Copy link
Owner

Akuli commented Jul 8, 2023

We basically need more producers (most plugins) and more consumers (key bindings, menubar, command palette, ...). Once actions.py is in place, I think these don't really depend on each other and we can work on whatever we find interesting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants