<fix>[expon]: decode url if complex password

Resolves: ZSTAC-65479

Change-Id: I6b7876626c686f787362646e73636570666e6d63

Author: MaJin1996

plugin/expon/src/main/java/org/zstack/expon/ExponStorageController.java

@@ -52,7 +52,9 @@
 import org.zstack.utils.path.PathUtil;
 import org.zstack.vhost.kvm.VhostVolumeTO;
 
+import java.io.UnsupportedEncodingException;
 import java.net.URI;
+import java.net.URLDecoder;
 import java.util.*;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
@@ -122,7 +124,11 @@ public ExponStorageController(String url) {
 
         AccountInfo accountInfo = new AccountInfo();
         accountInfo.username = uri.getUserInfo().split(":")[0];
-        accountInfo.password = uri.getUserInfo().split(":")[1];
+        try {
+            accountInfo.password = URLDecoder.decode(uri.getUserInfo().split(":")[1], "utf-8");
+        } catch (UnsupportedEncodingException e) {
+            throw new RuntimeException(e);
+        }
 
         apiHelper = new ExponApiHelper(accountInfo, client);
     }

test/src/test/groovy/org/zstack/test/integration/storage/primary/addon/ExternalPrimaryStorageCase.groovy

@@ -187,6 +187,7 @@ class ExternalPrimaryStorageCase extends SubCase {
             KVMGlobalConfig.VM_SYNC_ON_HOST_PING.updateValue(true)
             simulatorEnv()
             testCreateExponStorage()
+            testComplexPassword()
             testSessionExpired()
             testCreateVm()
             testHandleInactiveVolume()
@@ -299,6 +300,15 @@ class ExternalPrimaryStorageCase extends SubCase {
         }
     }
 
+    void testComplexPassword() {
+        String pswd = "Pswd@#123"
+        String encodePswd = URLEncoder.encode(pswd, "UTF-8")
+        discoverExternalPrimaryStorage {
+            url = String.format("https://complex:%[email protected]:443/pool", encodePswd)
+            identity = "expon"
+        }
+    }
+
     void testSessionExpired() {
         controller.apiHelper.sessionId = "invalid"
     }