CatalogViewのスピナーの非表示制御をfinally句へ移動 #1959
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjiyoshid-a
added
target: Dressca
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
この Pull request で実施したこと
consumerのカタログ一覧表示画面のローディング・スピナーの非表示制御をtry-catchの外に記述されていました。意図せぬエラーでスピナーが表示され続ける可能性があるため、スピナーの非表示をfinally句で行うように修正しました。
この Pull request では実施していないこと
admin側のローディング・スピナーの修正は以下のIssueで対応します。
Issues や Discussions 、関連する Web サイトなどへのリンク