Merge pull request matplotlib#10538 from tacaswell/fix_offsetbox

FIX: TypeError when using offset box in expand mode with tightlayout

Author: dstansby

lib/matplotlib/offsetbox.py

@@ -83,6 +83,10 @@ def _get_packed_offsets(wd_list, total, sep, mode="fixed"):
             sep = 0
         offsets_ = np.cumsum([0] + [w + sep for w in w_list])
         offsets = offsets_[:-1]
+        # this is a bit of a hack to avoid a TypeError when used
+        # in conjugation with tight layout
+        if total is None:
+            total = 1
         return total, offsets
 
     elif mode == "equal":

lib/matplotlib/tests/test_offsetbox.py

@@ -98,3 +98,19 @@ def test_offsetbox_loc_codes():
         anchored_box = AnchoredOffsetbox(loc=code, child=da)
         ax.add_artist(anchored_box)
     fig.canvas.draw()
+
+
+def test_expand_with_tight_layout():
+    fig = plt.figure()
+    axes = fig.add_subplot(111)
+
+    d1 = [29388871, 12448, 40, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+          0, 0, 0]
+    d2 = [28396236, 981940, 22171, 537, 123, 88, 41, 42, 40, 26, 26,
+          84, 6, 2, 0, 0, 0, 0, 0]
+    axes.plot(d1, label='series 1')
+    axes.plot(d2, label='series 2')
+    axes.legend(mode='expand')
+
+    # ### THIS IS WHERE THE CRASH HAPPENS
+    plt.tight_layout(rect=[0, 0.08, 1, 0.92])