Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in new_nac_homs! #78

Open
kris-brown opened this issue Aug 1, 2024 · 1 comment
Open

Bug in new_nac_homs! #78

kris-brown opened this issue Aug 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kris-brown
Copy link
Collaborator

The logic of new_nac_homs! is to find, after a deletion $f: X \leftarrowtail X'$, new morphisms which may have arisen due to a NAC $n: L \rightarrow N$ being deactivated.

This is done via finding morphisms $h: N\rightarrow X$ that meet some property, then pulling back $n \cdot h$ along $f$ to obtain the match $L\rightarrow X'$. However, something is awry in defining "some property", since the code presently allows $h$ to map parts of $L$ into deleted parts of $X$, which make the pulled back morphism $L\rightarrow X'$ undefined. So that logic needs to be looked into + improved.

@kris-brown kris-brown self-assigned this Aug 1, 2024
@kris-brown
Copy link
Collaborator Author

I think one issue here might be the fact that, for SPO rewriting, the effect of the deletion can extend beyond the context of where the rule was explicitly applied. It would be good to check whether this bug can affect DPO rules or just SPO rules - perhaps there is a less efficient strategy to take when the rule applied is SPO.

@kris-brown kris-brown added the bug Something isn't working label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant