attempt 2

Author: Lynech

task_01/src/main.cpp

@@ -5,7 +5,7 @@
 int main() {
   int a[] = {1, 2, 3, 4, 5, 6, 7, 8, 9};
   int m = 5;
-  std::tuple<bool, int*, int*> b = topology_sort(a, 9, m);
+  std::tuple<bool, int*, int*> b = SummanddsInArray(a, 9, m);
   if (std::get<0>(b)) {
     std::cout << "found" << std::endl;
     std::cout << std::get<1>(b) << " : " << *std::get<1>(b) << std::endl;

task_01/src/test.cpp

@@ -3,79 +3,95 @@
 
 #include "topology_sort.hpp"
 
-TEST(TopologySort, Simple1) {
+TEST(SummanddsInArray, Simple1) {
   int arr[] = {1, 2, 3, 4, 5, 6, 7, 8, 9};
   int n = 9;
   int m = 11;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), true);
   ASSERT_EQ(*std::get<1>(a) + *std::get<2>(a), m);
 }
 
-TEST(TopologySort, Simple2) {
+TEST(SummanddsInArray, Simple2) {
   int arr[] = {1, 2, 3, 4, 5, 8, 9};
   int n = 7;
   int m = 5;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), true);
   ASSERT_EQ(*std::get<1>(a) + *std::get<2>(a), m);
 }
-TEST(TopologySort, Simple3) {
+TEST(SummanddsInArray, Simple3) {
   int arr[] = {1, 2, 3, 4, 5, 6, 7, 8, 9};
   int n = 9;
   int m = 3;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), true);
   ASSERT_EQ(*std::get<1>(a) + *std::get<2>(a), m);
 }
 
-TEST(TopologySort, Simple4) {
+TEST(SummanddsInArray, Simple4) {
   int arr[] = {1, 3, 5, 7, 9};
   int n = 5;
   int m = 7;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), false);
 }
 
-TEST(TopologySort, Nullarr) {
+TEST(SummanddsInArray, Nullarr) {
   int* arr = nullptr;
   int n = 9;
   int m = 3;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), false);
 }
 
-TEST(TopologySort, Specific1) {
+TEST(SummanddsInArray, Specific1) {
   int arr_ref[] = {10, 2, 3, 4, 5, 5, 7, 8, 0};
   int* arr = arr_ref + 1;
-  int n = 7;
+  int n = 9;
   int m = 5;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), true);
   ASSERT_EQ(*std::get<1>(a) + *std::get<2>(a), m);
 }
 
-TEST(TopologySort, Specific2) {
+TEST(SummanddsInArray, Specific2) {
   int arr[] = {1, 2, 4, 5, 8};
-  int n = 7;
+  int n = 5;
   int m = 8;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), false);
 }
 
-TEST(TopologySort, Specific3) {
+TEST(SummanddsInArray, Specific3) {
   int arr[] = {1, 3, 4, 5, 8};
-  int n = 7;
+  int n = 5;
   int m = 16;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), false);
 }
 
-TEST(TopologySort, Specific4) {
+TEST(SummanddsInArray, Specific4) {
   int arr[] = {1, 3, 4, 5, 5, 8};
   int n = 6;
   int m = 10;
-  std::tuple<bool, int*, int*> a = topology_sort(arr, n, m);
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
   ASSERT_EQ(std::get<0>(a), true);
   ASSERT_EQ(*std::get<1>(a) + *std::get<2>(a), m);
+}
+
+TEST(SummanddsInArray, Specific5) {
+  int arr[] = {};
+  int n = 0;
+  int m = 10;
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
+  ASSERT_EQ(std::get<0>(a), false);
+}
+
+TEST(SummanddsInArray, Specific6) {
+  int arr[] = {10};
+  int n = 1;
+  int m = 20;
+  std::tuple<bool, int*, int*> a = SummanddsInArray(arr, n, m);
+  ASSERT_EQ(std::get<0>(a), false);
 }

task_01/src/topology_sort.cpp

@@ -1,16 +1,16 @@
 #include "topology_sort.hpp"
 
-std::tuple<bool, int *, int *> topology_sort(int *arr, int n, int m) {
-  int *b = arr, *e = arr + (n - 1);
-  bool found = 1;
-  while (b && e && b != e && *b + *e != m)
-    if ((*b + *e) > m)
-      e--;
+std::tuple<bool, int *, int *> SummanddsInArray(int *arr, int n, int sum) {
+  int *begin = arr, *end = arr + (n - 1);
+  bool found = true;
+  while (begin && end && begin < end && *begin + *end != sum)
+    if ((*begin + *end) > sum)
+      end--;
     else
-      b++;
-  if ((!b) || (!e) || (b == e) || (*b + *e != m)) {
-    b = e = nullptr;
+      begin++;
+  if ((!begin) || (!end) || (begin >= end) || (*begin + *end != sum)) {
+    begin = end = nullptr;
     found = 0;
   }
-  return std::tuple<bool, int *, int *>{found, b, e};
+  return std::tuple<bool, int *, int *>{found, begin, end};
 }

task_01/src/topology_sort.hpp

@@ -3,6 +3,6 @@
 
 #include <tuple>
 
-std::tuple<bool, int*, int*> topology_sort(int* arr, int n, int m);
+std::tuple<bool, int*, int*> SummanddsInArray(int* arr, int n, int m);
 
 #endif