Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolver] Git LFS Support #6156

Open
chetanpepper opened this issue Jan 8, 2025 · 3 comments · May be fixed by #6866
Open

[Resolver] Git LFS Support #6156

chetanpepper opened this issue Jan 8, 2025 · 3 comments · May be fixed by #6866
Labels
enhancement New feature or request openhands Have Openhands attempt to fix the issue (via GH App) resolver Related to OpenHands Resolver

Comments

@chetanpepper
Copy link

chetanpepper commented Jan 8, 2025

What problem or use case are you trying to solve?
I have a repo with a lot of data files stored in Git LFS. It looks like OpenHands clones the repo here.

I'm running on Github Actions and have tried passing GIT_LFS_SKIP_SMUDGE: 1 as an environment variable, but it doesn't seem to have an effect.

The Github action ends up failing due to lack of storage space.

Describe the UX of the solution you'd like
Environment variable that can be passed to the container to skip large LFS files on clone.

Do you have thoughts on the technical implementation?
Add an environment variable to the workflow that will accept parameters to git clone, GIT_LFS_SKIP_SMUDGE and --depth most importantly

Describe alternatives you've considered
I could fork openhands and modify the clone command.

Additional context
Workflow file:

name: Resolve Issue with OpenHands

on:
  issues:
    types: [labeled]
  pull_request:
    types: [labeled]
  issue_comment:
    types: [created]
  pull_request_review_comment:
    types: [created]
  pull_request_review:
    types: [submitted]

permissions:
  contents: write
  pull-requests: write
  issues: write

env:
  GIT_LFS_SKIP_SMUDGE: '1'
  
jobs:
  call-openhands-resolver:
    uses: All-Hands-AI/OpenHands/.github/workflows/openhands-resolver.yml@main
    with:
      macro: ${{ vars.OPENHANDS_MACRO || '@openhands-agent' }}
      max_iterations: ${{ fromJson(vars.OPENHANDS_MAX_ITER || 50) }}
      base_container_image: ${{ vars.OPENHANDS_BASE_CONTAINER_IMAGE || '' }}
      LLM_MODEL: ${{ vars.LLM_MODEL || 'anthropic/claude-3-5-sonnet-20241022' }}
    secrets:
      PAT_TOKEN: ${{ secrets.PAT_TOKEN }}
      PAT_USERNAME: ${{ secrets.PAT_USERNAME }}
      LLM_API_KEY: ${{ secrets.LLM_API_KEY }}
      LLM_BASE_URL: ${{ secrets.LLM_BASE_URL }}
@chetanpepper chetanpepper added the enhancement New feature or request label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Feb 8, 2025
@enyst enyst changed the title Git LFS Support [Resolver] Git LFS Support Feb 8, 2025
@enyst enyst added resolver Related to OpenHands Resolver and removed Stale Inactive for 30 days labels Feb 8, 2025
@malhotra5
Copy link
Contributor

Yes, we should try to use an ENV in the workflow, and pipe it into the comment included here

https://github.com/All-Hands-AI/OpenHands/blob/main/openhands/resolver/resolve_issue.py#L432-#L439

@malhotra5 malhotra5 added the openhands Have Openhands attempt to fix the issue (via GH App) label Feb 20, 2025
Copy link

openhands-ai bot commented Feb 20, 2025

I'm working on a fix! @malhotra5 can track my progress at all-hands.dev

@malhotra5 malhotra5 linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request openhands Have Openhands attempt to fix the issue (via GH App) resolver Related to OpenHands Resolver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants