Commit 860cab1
fix(tui): make the flush test assert its own claim, and stop y/n propagation
Two remaining review points.
The test named "enabling yolo clears a prompt that is already on screen" only
asserted that a reply was sent — never that the prompt left the screen, which is
the behaviour in its name. It now asserts the pending list empties. This works
without emitting `permission.replied` because autoApprove removes the request
optimistically on success.
Adds `stopPropagation()` to the dialog's `y` and `n` branches, matching the
`return` branch. Two reviewers disagreed on whether this is load-bearing: the
dialog blurs the focused renderable on open and refocuses in a later tick, so a
stray character cannot reach the prompt today. It is free consistency that keeps
that true if the ordering ever changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01964Prd1Sz5JwWZmNTrFdiU1 parent e8e42c7 commit 860cab1
2 files changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
59 | 63 | | |
60 | 64 | | |
| 65 | + | |
61 | 66 | | |
62 | 67 | | |
63 | 68 | | |
64 | 69 | | |
65 | 70 | | |
| 71 | + | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
217 | 221 | | |
218 | 222 | | |
219 | 223 | | |
| |||
0 commit comments