Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign Message: allow v1 accs to sign anything if OG mode is activated #1334

Open
wants to merge 5 commits into
base: v2
Choose a base branch
from
Open

Sign Message: allow v1 accs to sign anything if OG mode is activated #1334

wants to merge 5 commits into from

Conversation

JIOjosBG
Copy link
Member

@JIOjosBG JIOjosBG commented Feb 25, 2025 •
edited
Loading

Self explanatory - if the user has OG mode activated, do not disallow message signatures for V1 accs

To test

  • attempt to sign a plaintext or typed message, that does not include the address of the accounts (should not be allowed)
  • activate OG mode
  • attempt step 1 again, but now should be successful

Resolves: https://github.com/AmbireTech/ambire-app/issues/4034

@JIOjosBG JIOjosBG added the enhancement New feature or request label Feb 25, 2025
@JIOjosBG JIOjosBG requested a review from superKalo February 25, 2025 13:53
@JIOjosBG JIOjosBG self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivshti Ivshti Ivshti approved these changes

@superKalo superKalo Awaiting requested review from superKalo

Assignees

@JIOjosBG JIOjosBG

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JIOjosBG @Ivshti