Add test coverage for settlements/[id]/page.tsx's notFound() branches

[Jagadeeshftw]

📌 Description

SettlementDetailPage (src/app/settlements/[id]/page.tsx) contains real branching logic with no test coverage at all: it calls notFound() when the route param isn't a finite number (if (!Number.isFinite(numericId)) { notFound(); }), and separately calls notFound() when fetchSettlement throws an ApiRequestError with status === 404 (re-throwing any other error). Unlike its sibling anchors/[id]/error.test.tsx/anchors/[id]/loading.test.tsx, there is no settlements/[id]/page.test.tsx (or equivalent) exercising either of these branches, so a regression in the id-parsing or 404-mapping logic would go unnoticed by the test suite.

🧩 Requirements and context

• Add test coverage for SettlementDetailPage's three meaningful branches: (1) a non-numeric id param triggers notFound(), (2) fetchSettlement throwing an ApiRequestError with status === 404 triggers notFound(), and (3) a successful fetch renders SettlementDetail with the fetched data as initialData.
• Mock next/navigation's notFound (it throws in the real Next.js runtime to halt rendering) and src/lib/settlementsApi's fetchSettlement following the conventions already used in the existing error.test.tsx/loading.test.tsx files for this route segment.
• No production code changes are expected; this is purely closing a test-coverage gap on already-shipped logic.

🛠️ Suggested execution

• Create src/app/settlements/[id]/page.test.tsx, awaiting the async Server Component directly (as is already done for other async Server Component tests in this codebase, if any precedent exists) or rendering it via a small test harness, mocking fetchSettlement and next/navigation's notFound.
• Cover the three branches described above, asserting notFound() is called (or not) as appropriate and that a successful fetch's data reaches SettlementDetail.

✅ Acceptance criteria

• A non-numeric settlement id param is covered by a test asserting notFound() fires.
• A 404 ApiRequestError from fetchSettlement is covered by a test asserting notFound() fires.
• A successful fetch is covered by a test asserting the page renders with the fetched data.

🔒 Security notes

No new attack surface; a test-coverage task on already-shipped routing/error-mapping logic.

📋 Guidelines

• Minimum 95% test coverage
• Clear documentation
• Timeframe: 96 hours

[Muhamadmust]

Hi maintainer
I have reviewed this issue and would like to work on it, PR 2days

[egwujiohaifesinachiperpetual-max]

Hello boss, Please assign this issue to me. i checked it out and im confident i will solve it
my eta is 4 hours

[github-actions]

Assigned @egwujiohaifesinachiperpetual-max to this issue. Please open a PR referencing this issue (e.g. Closes #271) when you're ready.