Add test to cover situation where no ignore attribute was requested

Author: RiRiSharp

src/AngleSharp.Diffing.Tests/DiffBuilderTest.cs

@@ -1,3 +1,8 @@
+using AngleSharp.Diffing.Strategies;
+using AngleSharp.Diffing.Strategies.AttributeStrategies;
+using AngleSharp.Diffing.Strategies.TextNodeStrategies;
+using AngleSharp.Diffing.TestData;
+
 namespace AngleSharp.Diffing;
 
 
@@ -119,22 +124,35 @@ public void Test006(string control, string test)
 
     [Theory(DisplayName =
         "When a control element has ':ignore', elements with and without that attribute should return empty diffs")]
-    [InlineData("<div class:ignore></div>", "<div class=\"ian-fleming\"></div>")]
-    [InlineData("<div class:ignore></div>", "<div class=\"\"></div>")]
-    [InlineData("<div class:ignore></div>", "<div class></div>")]
-    [InlineData("<div class:ignore></div>", "<div></div>")]
-    [InlineData("<input required:ignore/>", "<input required=\"required\"/>")]
-    [InlineData("<input required:ignore/>", "<input required=\"\"/>")]
-    [InlineData("<input required:ignore/>", "<input required/>")]
-    [InlineData("<input required:ignore/>", "<input/>")]
-    [InlineData("<button onclick:ignore/></button>", "<button onclick=\"alert(1)\"></button>")]
-    [InlineData("<button onclick:ignore/></button>", "<button/></button>")]
-    [InlineData("<a aria-disabled:ignore/></a>", "<a aria-disabled=\"true\"/></a>")]
-    [InlineData("<a aria-disabled:ignore/></a>", "<a/></a>")]
+    [MemberData(nameof(IgnoreAttributeTestData.ControlAndHtmlData), MemberType = typeof(IgnoreAttributeTestData))]
     public void Test007(string controlHtml, string testHtml)
     {
         var diffs = DiffBuilder.Compare(controlHtml).WithTest(testHtml).Build();
         Assert.Empty(diffs);
     }
 
-}
+    [Theory(DisplayName =
+        "When a control element has ':ignore', but IgnoreAttributeComparer is not active, diffs should be found")]
+    [MemberData(nameof(IgnoreAttributeTestData.ControlHtmlAndDiffData), MemberType = typeof(IgnoreAttributeTestData))]
+    public void Test008(string controlHtml, string testHtml, DiffResult expectedDiffResult)
+    {
+        var diffs = DiffBuilder
+            .Compare(controlHtml)
+            .WithTest(testHtml)
+            .WithOptions(a => a // Most important thing to note here is we do not have a ignore attribute comparer
+                .AddSearchingNodeMatcher()
+                .AddAttributeNameMatcher()
+                .AddElementComparer(enforceTagClosing: false)
+                .AddMatcher(PostfixedAttributeMatcher.Match, StrategyType.Specialized)
+                .AddComparer(AttributeComparer.Compare, StrategyType.Generalized)
+                .AddClassAttributeComparer()
+                .AddBooleanAttributeComparer(BooleanAttributeComparision.Strict)
+                .AddStyleAttributeComparer())
+            .Build()
+            .ToList();
+
+        Assert.Single(diffs);
+        Assert.Equal(DiffTarget.Attribute, diffs[0].Target);
+        Assert.Equal(expectedDiffResult, diffs[0].Result);
+    }
+}

src/AngleSharp.Diffing.Tests/TestData/IgnoreAttributeTestData.cs

@@ -0,0 +1,45 @@
+namespace AngleSharp.Diffing.TestData;
+
+internal static class IgnoreAttributeTestData
+{
+    public static TheoryData<string, string> ControlAndHtmlData()
+    {
+        var theoryData = new TheoryData<string, string>();
+        foreach (var (controlHtml, expectedHtml, _) in TestCases)
+        {
+            theoryData.Add(controlHtml, expectedHtml);
+        }
+
+        return theoryData;
+    }
+
+    public static TheoryData<string, string, DiffResult> ControlHtmlAndDiffData()
+    {
+        var theoryData = new TheoryData<string, string, DiffResult>();
+        foreach (var (controlHtml, expectedHtml, expectedDiffResult) in TestCases)
+        {
+            theoryData.Add(controlHtml, expectedHtml, expectedDiffResult);
+        }
+
+        return theoryData;
+    }
+
+    private static readonly IEnumerable<(string controlHtml, string expectedHtml, DiffResult expectedDiffResult)>
+        TestCases =
+        [
+            ("<div class:ignore></div>", "<div class=\"ian-fleming\"></div>", DiffResult.Different),
+            ("<div class:ignore></div>", "<div class=\"\"></div>", DiffResult.Different),
+            ("<div class:ignore></div>", "<div class></div>", DiffResult.Different),
+            ("<div class:ignore></div>", "<div></div>", DiffResult.Missing),
+            ("<input required:ignore/>", "<input required=\"required\"/>", DiffResult.Different),
+            ("<input required:ignore/>", "<input required=\"\"/>", DiffResult.Different),
+            ("<input required:ignore/>", "<input required/>", DiffResult.Different),
+            ("<input required:ignore/>", "<input/>", DiffResult.Missing),
+            ("<button onclick:ignore/></button>", "<button onclick=\"alert(1)\"></button>", DiffResult.Different),
+            ("<button onclick:ignore/></button>", "<button/></button>", DiffResult.Missing),
+            ("<a aria-disabled:ignore/></a>", "<a aria-disabled=\"true\"/></a>", DiffResult.Different),
+            ("<a aria-disabled:ignore/></a>", "<a/></a>", DiffResult.Missing),
+            ("<span style:ignore/></span>", "<span style=\"color:red;\"/></span>", DiffResult.Different),
+            ("<span style:ignore/></span>", "<span/></span>", DiffResult.Missing),
+        ];
+}