is_consistent is unused and untested — wire it into the post-tally integrity check

[grantfox-oss]

Suggested area: Rust, TypeScript

Summary

is_consistent(ballot_id_hash) is the most operationally valuable
function in the contract — it returns true only when
tokens_issued == votes_cast, giving anyone a single on-chain call
to confirm no votes were dropped or duplicated. Despite this, it is
never called from sorobanService.ts, never called from core, and
has no test in cargo test. It exists in lib.rs but has zero
coverage and zero callers.

Scope

• Add a unit test in contracts/anonvote/src/lib.rs covering
  is_consistent — test the true case where tokens and votes match,
  the false case where they differ, and the case where the ballot
  does not exist
• Add a sorobanIsConsistent(ballotIdHash: string): Promise<boolean>
  function to service/sorobanService.ts following the same pattern
  as the existing view call wrappers
• Document in the README that is_consistent is the recommended
  integrity check after tally — explain what a false return means
  and what a maintainer should do if it fires
• Add a note in the wiring table in the README mapping
  sorobanIsConsistent to services/resultEngine.ts in core as
  the recommended call site after sorobanRecordResult

Relevant files

• contracts/anonvote/src/lib.rs
• service/sorobanService.ts
• README.md

Acceptance Criteria

• is_consistent has unit tests covering true, false, and
  ballot-not-found cases
• sorobanIsConsistent added to sorobanService.ts with
  correct TypeScript types
• cargo test passes with the new tests included
• README documents is_consistent as the post-tally integrity
  check with guidance on what a false return means
• Wiring table updated to reference sorobanIsConsistent
  and resultEngine.ts

Out of scope

• Wiring sorobanIsConsistent into core — that belongs in an
  AnonVote/core issue
• Changes to other contract functions

[edehvictor]

Hey, can I work on this

[Sparexonzy95]

Hi Team,

I'd like to work on this issue.

I noticed that "is_consistent" is a critical integrity-check function but currently has no coverage and is not exposed through the service layer. I'll add comprehensive contract tests covering the true, false, and ballot-not-found scenarios, implement the TypeScript wrapper in "sorobanService.ts", and update the README to document its role as the recommended post-tally verification check.

This will improve confidence in vote integrity verification while ensuring the functionality is properly documented and accessible for future integration.

Looking forward to contributing.

[grantfox-oss]

🦊 GrantFox — @edehvictor has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #65)
2. Your PR will be reviewed by the AnonVote maintainers

Good luck! Track your progress on GrantFox.