[Feature] Two different modes of OSD working simultaneously

[lida2003]

Feature request

Two different modes of OSD working simultaneously

Details: https://discuss.ardupilot.org/t/is-it-possible-for-two-osd-resolution-working-at-the-same-time/125505

Platform
[ ] All
[ ] AntennaTracker
[x] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Additional context
Copter 4.5.6 Analog+ MSP Display port

25/1/23 17:35:56 : ChibiOS: 6a85082c
25/1/23 17:35:56 : ArduCopter V4.5.6 (b867abc8)
25/1/23 17:35:56 : Frame: QUAD/X_REV
25/1/23 17:35:56 : RCOut: DS600:1-4 PWM:5-13
25/1/23 17:35:56 : Aocoda-RC-H743Dual 00290029 30315119 

[lida2003]

How about add an OSD_CONCURRENTLY = 3 below for anlog+msp display port as guide says: https://ardupilot.org/copter/docs/common-osd-overview.html#osd or what I want in discussion: https://discuss.ardupilot.org/t/is-it-possible-for-two-osd-resolution-working-at-the-same-time/125505

Hope someone familiar with the code can give some tips and join the discussion here.

ardupilot/libraries/AP_OSD/AP_OSD.h

Lines 560 to 563 in 00c1f14

	enum switch_method {
	TOGGLE=0,
	PWM_RANGE=1,
	AUTO_SWITCH=2,

Add code when following conditions are met:

• switch_method = OSD_CONCURRENTLY
• OSD screen is enabled
• OSD_TYPEx is porperly set

ardupilot/libraries/AP_OSD/AP_OSD.cpp

Lines 555 to 605 in 00c1f14

	switch (sw_method) {
	//switch to next screen if channel value was changed
	default:
	case TOGGLE:
	if (previous_channel_value == 0) {
	//do not switch to the next screen just after initialization
	previous_channel_value = channel_value;
	}
	if (abs(channel_value-previous_channel_value) > 200) {
	if (switch_debouncer) {
	next_screen();
	previous_channel_value = channel_value;
	} else {
	switch_debouncer = true;
	return;
	}
	}
	break;
	//select screen based on pwm ranges specified
	case PWM_RANGE:
	for (int i=0; i<AP_OSD_NUM_SCREENS; i++) {
	if (get_screen(i).enabled && get_screen(i).channel_min <= channel_value && get_screen(i).channel_max > channel_value) {
	if (previous_pwm_screen == i) {
	break;
	} else {
	current_screen = previous_pwm_screen = i;
	}
	}
	}
	break;
	//switch to next screen after low to high transition and every 1s while channel value is high
	case AUTO_SWITCH:
	if (channel_value > channel->get_radio_trim()) {
	if (switch_debouncer) {
	uint32_t now = AP_HAL::millis();
	if (now - last_switch_ms > 1000) {
	next_screen();
	last_switch_ms = now;
	}
	} else {
	switch_debouncer = true;
	return;
	}
	} else {
	last_switch_ms = 0;
	}
	break;
	}
	switch_debouncer = false;
	#endif // AP_RC_CHANNEL_ENABLED
	}

[lida2003]

I also find an issue when OSD init:

• init procedure asked if it's compatible
• MSP Display responses with false
• then the init_backend returns, there will be NO probe
• finally, _backend_count will not be increased in AP_OSD::init

I'm NOT sure if it works this way?

ardupilot/libraries/AP_OSD/AP_OSD.cpp

Lines 321 to 328 in 00c1f14

	bool AP_OSD::init_backend(const AP_OSD::osd_types type, const uint8_t instance)
	{
	// check if we can run this backend instance in parallel with backend instance 0
	if (instance > 0) {
	if (_backends[0] && !_backends[0]->is_compatible_with_backend_type(type)) {
	return false;
	}
	}

ardupilot/libraries/AP_OSD/AP_OSD_MSP_DisplayPort.h

Lines 34 to 38 in 00c1f14

	bool is_compatible_with_backend_type(AP_OSD::osd_types type) const override {
	switch(type) {
	case AP_OSD::osd_types::OSD_MSP:
	case AP_OSD::osd_types::OSD_MSP_DISPLAYPORT:
	return false;

[lida2003]

I think I may understand OSD not correctly.

Here is the case:

• I have analog Camera with: OSD_TYPE=1, OSD screen 1 (30x16)
• Another OpenIPC digital Camera with: OSD_TYPE2=5, OSD screen 2(50x18)

Now the issue is all OSD uses OSD screen 1(30x16). Right now, it's working simultaneously, but OSD layout is not what I expected.

The code seems to run only one OSD screen, and it can't be used for two OSD screen simultaneouosly.

[lida2003]

Here is the PR for this: #29149

• Changes for custom build
• Video: Ardupilot Analog + Digital(OpenIPC) Camera OSD Concurrently Support
• How to configure