[Backend] — Bug/Test: `NotificationsService.markAsRead` silently ignores wrong-owner updates

[Olowodarey]

Background

NotificationsService.markAsRead (src/notifications/notifications.service.ts)
calls this.notificationsRepository.update({ id, user_address }, { read: true }).
When id exists but user_address doesn't match, result.affected is 0 but no
error is thrown. A client that guesses a notification ID from another user would
get a silent success.

Goal

Throw NotFoundException when affected == 0.

Requirements

1. In NotificationsService.markAsRead, update to:

2. Add tests in src/notifications/notifications.service.spec.ts:

   • Correct owner: result.affected = 1 → no error, broadcaster called.
   • Wrong owner: result.affected = 0 → NotFoundException.

Acceptance criteria

• Marking another user's notification throws 404.
• Correct notification marked and broadcaster called.

[otobongdev]

@otobongdev has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I will like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @otobongdev to this issue.

[gloskull]

Hello, I have 4 years of experience delivering solutions for projects like this, covering backend, frontend, and smart contract development. After carefully reviewing your requirements, I have a clear understanding of the task and am confident in my ability to deliver a clean, efficient, and thoroughly tested solution on time. I prioritize code quality, maintainability, and industry best practices throughout the development process.
My PR will be submitted in under 10hours.

[Diyaq]

@Diyaq has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Diyaq to this issue.

[drips-wave]

Congratulations, @Diyaq! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @Diyaq: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🦊 GrantFox — @Diyaq has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #1099)
2. Your PR will be reviewed by the Arena1X maintainers

Good luck! Track your progress on GrantFox.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!

@Diyaq's PR #1234 was approved and merged by @Olowodarey.

🏆 @Diyaq: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (48 total points). Track your full progress on GrantFox.

👏 Great work, @Diyaq! Keep contributing to Arena1X.

[drips-wave]

This issue has been completed by @Diyaq as part of the Stellar Wave Program's 6th Wave 🥳

😎 @Diyaq: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.