Skip to content

Commit 7ec33a4

Browse files
authored
Renumber now-pedantic diagnostic from 232 to 907 (#2001)
1 parent a0307d8 commit 7ec33a4

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/diagnosticMessages.generated.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ export enum DiagnosticCode {
4646
Property_0_only_has_a_setter_and_is_missing_a_getter = 229,
4747
_0_keyword_cannot_be_used_here = 230,
4848
A_class_with_a_constructor_explicitly_returning_something_else_than_this_must_be_final = 231,
49-
Exported_generic_function_or_class_has_no_concrete_instances = 232,
5049
Property_0_is_always_assigned_before_being_used = 233,
5150
Expression_refers_to_a_static_element_that_does_not_compile_to_a_value_at_runtime = 234,
5251
Importing_the_table_disables_some_indirect_call_optimizations = 901,
@@ -55,6 +54,7 @@ export enum DiagnosticCode {
5554
Indexed_access_may_involve_bounds_checking = 904,
5655
Explicitly_returning_constructor_drops_this_allocation = 905,
5756
Unnecessary_definite_assignment = 906,
57+
Exported_generic_function_or_class_has_no_concrete_instances = 907,
5858
Unterminated_string_literal = 1002,
5959
Identifier_expected = 1003,
6060
_0_expected = 1005,
@@ -228,7 +228,6 @@ export function diagnosticCodeToString(code: DiagnosticCode): string {
228228
case 229: return "Property '{0}' only has a setter and is missing a getter.";
229229
case 230: return "'{0}' keyword cannot be used here.";
230230
case 231: return "A class with a constructor explicitly returning something else than 'this' must be '@final'.";
231-
case 232: return "Exported generic function or class has no concrete instances.";
232231
case 233: return "Property '{0}' is always assigned before being used.";
233232
case 234: return "Expression refers to a static element that does not compile to a value at runtime.";
234233
case 901: return "Importing the table disables some indirect call optimizations.";
@@ -237,6 +236,7 @@ export function diagnosticCodeToString(code: DiagnosticCode): string {
237236
case 904: return "Indexed access may involve bounds checking.";
238237
case 905: return "Explicitly returning constructor drops 'this' allocation.";
239238
case 906: return "Unnecessary definite assignment.";
239+
case 907: return "Exported generic function or class has no concrete instances.";
240240
case 1002: return "Unterminated string literal.";
241241
case 1003: return "Identifier expected.";
242242
case 1005: return "'{0}' expected.";

src/diagnosticMessages.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"Property '{0}' only has a setter and is missing a getter.": 229,
4242
"'{0}' keyword cannot be used here.": 230,
4343
"A class with a constructor explicitly returning something else than 'this' must be '@final'.": 231,
44-
"Exported generic function or class has no concrete instances.": 232,
4544
"Property '{0}' is always assigned before being used.": 233,
4645
"Expression refers to a static element that does not compile to a value at runtime.": 234,
4746

@@ -51,6 +50,7 @@
5150
"Indexed access may involve bounds checking.": 904,
5251
"Explicitly returning constructor drops 'this' allocation.": 905,
5352
"Unnecessary definite assignment.": 906,
53+
"Exported generic function or class has no concrete instances.": 907,
5454

5555
"Unterminated string literal.": 1002,
5656
"Identifier expected.": 1003,

tests/compiler/export-generic.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
"--pedantic"
44
],
55
"stderr": [
6-
"AS232: Exported generic function or class has no concrete instances.",
6+
"AS907: Exported generic function or class has no concrete instances.",
77
"export function testFunction<T>",
8-
"AS232: Exported generic function or class has no concrete instances.",
8+
"AS907: Exported generic function or class has no concrete instances.",
99
"export class TestClass<T>",
10-
"AS232: Exported generic function or class has no concrete instances.",
10+
"AS907: Exported generic function or class has no concrete instances.",
1111
"public testMethod<T>()",
12-
"AS232: Exported generic function or class has no concrete instances.",
12+
"AS907: Exported generic function or class has no concrete instances.",
1313
"export function testNamespacedFunction<T>",
14-
"AS232: Exported generic function or class has no concrete instances.",
14+
"AS907: Exported generic function or class has no concrete instances.",
1515
"export class TestNamespacedClass<T>"
1616
]
1717
}

0 commit comments

Comments
 (0)