Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Legit phrasal verb "fight back" wrongly flagged to change into compound noun #742

Open
hippietrail opened this issue Feb 22, 2025 · 0 comments
Labels
bug Something isn't working harper-core linting

Comments

@hippietrail
Copy link
Contributor

Description

Correct sentence: Preparing a strategy to fight back then on February 2nd.

"To fight back" is a common English phrasal verb and is used correctly in this sentence.

Harper flags it as an error and suggests changing it to a closed noun compound "fightback".

"Fightback" is a real English word but it does not belong in this sentence and makes it ungrammatical. It actually causes a case of #384 which is a very common mistake English speakers already make.

Resources

#384 has details about phrasal verbs and their related compound nouns.

Screenshots

Image

Implementation thoughts

We should never turn a verb into a noun when the verb is grammatical. The particle to before the verb is probably quite reliable though there's a change there might be cases where it could look like a preposition before a noun.

We probably need a special linter or class of linters for deal with phrasal verb / compound noun pairs. They would mostly share the same logic and heuristics though a few could have special false-positive cases. In the end we might want a separate curated dictionary of these, but we may be able to manage without one.

@hippietrail hippietrail added bug Something isn't working harper-core linting labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working harper-core linting
Projects
None yet
Development

No branches or pull requests

1 participant