Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "let's walk out" flagged as a possessive noun followed by a compound noun #752

Open
hippietrail opened this issue Feb 23, 2025 · 0 comments
Labels
bug Something isn't working harper-core linting

Comments

@hippietrail
Copy link
Contributor

Description

Harper thinks "let's" is a noun "let" in possessive form. It's actually a contraction of the verb "to let" and "us" and forms what's called in linguistics the "hortative". As in "Let's go!"

On this basis it decides that the phrasal verb "walk out" is wrong and should be the noun "walkout".

This is partly a result of the way the affix engine treats M for appending -'s
-s has not one but two main meanings and in this case it's a third meaning:

Noun + -'s = possessive
Nominal (noun or pronoun) + -s = contraction of both "is" and "has"
"To let" + -s = contraction of "us"

One remedy for this is to have distinct flags for the possessive meaning and the contraction meaning.
Another remedy is to bolster the affix logic so that it only bestows the new metadata based on what the prior metadata was.

To ease dictionary maintenance either way, we could prefer separate adjacent entries in dictionary.dict for each homograph and/or sense. After all, our priorities are not the same as Hunspell's.

Screenshots

Image
@hippietrail hippietrail added bug Something isn't working harper-core linting labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working harper-core linting
Projects
None yet
Development

No branches or pull requests

1 participant