Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show disabled indicator test beside email title in email list #7752

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Show disabled indicator test beside email title in email list #7752

wants to merge 1 commit into from

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Feb 19, 2025

Resolves #7681

Proposed Changes

  • Adds a "Disabled" indicator text following "Draft" is shown on Posts and Pages list of WordPress

Testing Instructions

  1. Go to Sensei LMS -> Settings -> Emails
  2. Disable one or more email
  3. Make sure you see a "- Disabled" string at the end of the email titles
  4. Make sure you don't see it when the emails are enabled

I'm having some issues with tests, so will add that separately.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@Imran92 Imran92 requested a review from a team February 19, 2025 21:37
@Imran92 Imran92 self-assigned this Feb 19, 2025
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@merkushin merkushin added this to the 4.24.6 milestone Feb 20, 2025
merkushin
merkushin approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! 👍

Just checking—will you be adding a changelog entry here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkushin merkushin merkushin approved these changes

Assignees

@Imran92 Imran92

Labels
None yet
Projects
None yet
Milestone
4.24.6
Development

Successfully merging this pull request may close these issues.

Make it easier to visually understand which emails are enabled/disabled
2 participants
@Imran92 @merkushin