Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Commit 287f4f4

Browse files
committed
Improve docs
1 parent ed959fb commit 287f4f4

File tree

6 files changed

+6
-14
lines changed

6 files changed

+6
-14
lines changed

.github/workflows/verify-version.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88

99
jobs:
1010
verify-version:
11-
name: Verify plugin version
11+
name: Verify that plugin version matches SQLITE_DRIVER_VERSION constant
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v4

load.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
/**
1616
* Load the "SQLITE_DRIVER_VERSION" constant.
17-
* This constant needs to be updated whenever the plugin version changes!
17+
* This constant needs to be updated on plugin release!
1818
*/
1919
require_once __DIR__ . '/version.php';
2020

tests/WP_SQLite_Information_Schema_Reconstructor_Tests.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ class WP_SQLite_Information_Schema_Reconstructor_Tests extends TestCase {
1313
private $sqlite;
1414

1515
public static function setUpBeforeClass(): void {
16-
// if ( ! defined( 'PDO_DEBUG' )) {
17-
// define( 'PDO_DEBUG', true );
18-
// }
1916
if ( ! defined( 'FQDB' ) ) {
2017
define( 'FQDB', ':memory:' );
2118
define( 'FQDBDIR', __DIR__ . '/../testdb' );
@@ -30,7 +27,7 @@ public static function setUpBeforeClass(): void {
3027
$GLOBALS['wpdb']->show_errors = true;
3128
}
3229

33-
// Mock symols that are used for WordPress table reconstruction.
30+
// Mock symbols that are used for WordPress table reconstruction.
3431
if ( ! defined( 'ABSPATH' ) ) {
3532
define( 'ABSPATH', __DIR__ );
3633
}

version.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
/**
44
* The version of the SQLite driver.
55
*
6-
* This constant needs to be updated whenever the plugin version changes!
6+
* This constant needs to be updated on plugin release!
77
*/
88
define( 'SQLITE_DRIVER_VERSION', '2.1.17-alpha' );

wp-includes/sqlite-ast/class-wp-sqlite-information-schema-reconstructor.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ public function ensure_correct_information_schema(): void {
8080
foreach ( $tables as $table ) {
8181
if ( ! in_array( $table, $information_schema_tables, true ) ) {
8282
if ( isset( $wp_tables[ $table ] ) ) {
83-
// WordPress table.
83+
// WordPress core table (as returned by "wp_get_db_schema()").
8484
$sql = $wp_tables[ $table ];
8585
} else {
86-
// Non-WordPress table.
86+
// Other table (a WordPress plugin or unrelated to WordPress).
8787
$sql = $this->generate_create_table_statement( $table );
8888
}
8989
$ast = $this->driver->parse_query( $sql );
@@ -140,10 +140,6 @@ private function get_information_schema_table_names(): array {
140140
/**
141141
* Generate a MySQL CREATE TABLE statement from an SQLite table definition.
142142
*
143-
* This method generates a MySQL CREATE TABLE statement for a given table name.
144-
* It retrieves the column information from the SQLite database and generates
145-
* a CREATE TABLE statement that can be used to create the table in MySQL.
146-
*
147143
* @param string $table_name The name of the table.
148144
* @return string The CREATE TABLE statement.
149145
*/

wp-includes/sqlite/db.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
/**
1010
* Load the "SQLITE_DRIVER_VERSION" constant.
11-
* This constant needs to be updated whenever the plugin version changes!
1211
*/
1312
require_once dirname( __DIR__, 2 ) . '/version.php';
1413

0 commit comments

Comments
 (0)