refactor: payment method definition capability duplication (#11148)

Author: frosso

changelog/refactor-remove-payment-method-definition-duplicate-methods

@@ -0,0 +1,4 @@
+Significance: patch
+Type: update
+
+refactor: update payment method definition classes to delegate capabilities to PaymentMethodUtils

includes/payment-methods/Configs/Definitions/AffirmDefinition.php

@@ -77,42 +77,6 @@ public static function get_description( ?string $account_country = null ): strin
 		return __( 'Allow customers to pay over time with Affirm.', 'woocommerce-payments' );
 	}
 
-	/**
-	 * Is the payment method a BNPL (Buy Now Pay Later) payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_bnpl(): bool {
-		return PaymentMethodUtils::is_bnpl( self::get_capabilities() );
-	}
-
-	/**
-	 * Is the payment method a reusable payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_reusable(): bool {
-		return PaymentMethodUtils::is_reusable( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method accept only domestic payments?
-	 *
-	 * @return boolean
-	 */
-	public static function accepts_only_domestic_payments(): bool {
-		return PaymentMethodUtils::accepts_only_domestic_payments( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method allow manual capture?
-	 *
-	 * @return boolean
-	 */
-	public static function allows_manual_capture(): bool {
-		return PaymentMethodUtils::allows_manual_capture( self::get_capabilities() );
-	}
-
 	/**
 	 * Get the list of supported currencies
 	 *
@@ -227,15 +191,6 @@ public static function is_available_for( string $currency, string $account_count
 		return PaymentMethodUtils::is_available_for( self::get_supported_currencies(), self::get_supported_countries(), $currency, $account_country );
 	}
 
-	/**
-	 * Whether this payment method should be enabled by default
-	 *
-	 * @return bool
-	 */
-	public static function is_enabled_by_default(): bool {
-		return false;
-	}
-
 	/**
 	 * Get the minimum amount for this payment method for a given currency and country
 	 *

includes/payment-methods/Configs/Definitions/AlipayDefinition.php

@@ -77,42 +77,6 @@ public static function get_description( ?string $account_country = null ): strin
 		return __( 'Alipay is a popular wallet in China, operated by Ant Financial Services Group, a financial services provider affiliated with Alibaba.', 'woocommerce-payments' );
 	}
 
-	/**
-	 * Is the payment method a BNPL (Buy Now Pay Later) payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_bnpl(): bool {
-		return PaymentMethodUtils::is_bnpl( self::get_capabilities() );
-	}
-
-	/**
-	 * Is the payment method a reusable payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_reusable(): bool {
-		return PaymentMethodUtils::is_reusable( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method accept only domestic payments?
-	 *
-	 * @return boolean
-	 */
-	public static function accepts_only_domestic_payments(): bool {
-		return PaymentMethodUtils::accepts_only_domestic_payments( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method allow manual capture?
-	 *
-	 * @return boolean
-	 */
-	public static function allows_manual_capture(): bool {
-		return PaymentMethodUtils::allows_manual_capture( self::get_capabilities() );
-	}
-
 	/**
 	 * Get the list of supported currencies
 	 *
@@ -283,15 +247,6 @@ public static function is_available_for( string $currency, string $account_count
 		return PaymentMethodUtils::is_available_for( self::get_supported_currencies(), self::get_supported_countries(), $currency, $account_country );
 	}
 
-	/**
-	 * Whether this payment method should be enabled by default
-	 *
-	 * @return bool
-	 */
-	public static function is_enabled_by_default(): bool {
-		return false;
-	}
-
 	/**
 	 * Get the minimum amount for this payment method for a given currency and country
 	 *

includes/payment-methods/Configs/Definitions/BancontactDefinition.php

@@ -77,42 +77,6 @@ public static function get_description( ?string $account_country = null ): strin
 		return __( 'Bancontact is a bank redirect payment method offered by more than 80% of online businesses in Belgium.', 'woocommerce-payments' );
 	}
 
-	/**
-	 * Is the payment method a BNPL (Buy Now Pay Later) payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_bnpl(): bool {
-		return PaymentMethodUtils::is_bnpl( self::get_capabilities() );
-	}
-
-	/**
-	 * Is the payment method a reusable payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_reusable(): bool {
-		return PaymentMethodUtils::is_reusable( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method accept only domestic payments?
-	 *
-	 * @return boolean
-	 */
-	public static function accepts_only_domestic_payments(): bool {
-		return PaymentMethodUtils::accepts_only_domestic_payments( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method allow manual capture?
-	 *
-	 * @return boolean
-	 */
-	public static function allows_manual_capture(): bool {
-		return PaymentMethodUtils::allows_manual_capture( self::get_capabilities() );
-	}
-
 	/**
 	 * Get the list of supported currencies
 	 *
@@ -206,15 +170,6 @@ public static function is_available_for( string $currency, string $account_count
 		return PaymentMethodUtils::is_available_for( self::get_supported_currencies(), self::get_supported_countries(), $currency, $account_country );
 	}
 
-	/**
-	 * Whether this payment method should be enabled by default
-	 *
-	 * @return bool
-	 */
-	public static function is_enabled_by_default(): bool {
-		return false;
-	}
-
 	/**
 	 * Get the minimum amount for this payment method for a given currency and country
 	 *

includes/payment-methods/Configs/Definitions/EpsDefinition.php

@@ -77,42 +77,6 @@ public static function get_description( ?string $account_country = null ): strin
 		return __( 'Accept your payment with EPS — a common payment method in Austria.', 'woocommerce-payments' );
 	}
 
-	/**
-	 * Is the payment method a BNPL (Buy Now Pay Later) payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_bnpl(): bool {
-		return PaymentMethodUtils::is_bnpl( self::get_capabilities() );
-	}
-
-	/**
-	 * Is the payment method a reusable payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_reusable(): bool {
-		return PaymentMethodUtils::is_reusable( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method accept only domestic payments?
-	 *
-	 * @return boolean
-	 */
-	public static function accepts_only_domestic_payments(): bool {
-		return PaymentMethodUtils::accepts_only_domestic_payments( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method allow manual capture?
-	 *
-	 * @return boolean
-	 */
-	public static function allows_manual_capture(): bool {
-		return PaymentMethodUtils::allows_manual_capture( self::get_capabilities() );
-	}
-
 	/**
 	 * Get the list of supported currencies
 	 *
@@ -206,15 +170,6 @@ public static function is_available_for( string $currency, string $account_count
 		return PaymentMethodUtils::is_available_for( self::get_supported_currencies(), self::get_supported_countries(), $currency, $account_country );
 	}
 
-	/**
-	 * Whether this payment method should be enabled by default
-	 *
-	 * @return bool
-	 */
-	public static function is_enabled_by_default(): bool {
-		return false;
-	}
-
 	/**
 	 * Get the minimum amount for this payment method for a given currency and country
 	 *

includes/payment-methods/Configs/Definitions/GiropayDefinition.php

@@ -77,42 +77,6 @@ public static function get_description( ?string $account_country = null ): strin
 		return __( 'Expand your business with giropay — Germany\'s second most popular payment system.', 'woocommerce-payments' );
 	}
 
-	/**
-	 * Is the payment method a BNPL (Buy Now Pay Later) payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_bnpl(): bool {
-		return PaymentMethodUtils::is_bnpl( self::get_capabilities() );
-	}
-
-	/**
-	 * Is the payment method a reusable payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_reusable(): bool {
-		return PaymentMethodUtils::is_reusable( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method accept only domestic payments?
-	 *
-	 * @return boolean
-	 */
-	public static function accepts_only_domestic_payments(): bool {
-		return PaymentMethodUtils::accepts_only_domestic_payments( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method allow manual capture?
-	 *
-	 * @return boolean
-	 */
-	public static function allows_manual_capture(): bool {
-		return PaymentMethodUtils::allows_manual_capture( self::get_capabilities() );
-	}
-
 	/**
 	 * Get the list of supported currencies
 	 *
@@ -207,15 +171,6 @@ public static function is_available_for( string $currency, string $account_count
 		return PaymentMethodUtils::is_available_for( self::get_supported_currencies(), self::get_supported_countries(), $currency, $account_country );
 	}
 
-	/**
-	 * Whether this payment method should be enabled by default
-	 *
-	 * @return bool
-	 */
-	public static function is_enabled_by_default(): bool {
-		return false;
-	}
-
 	/**
 	 * Get the minimum amount for this payment method for a given currency and country
 	 *

includes/payment-methods/Configs/Definitions/IdealDefinition.php

@@ -77,42 +77,6 @@ public static function get_description( ?string $account_country = null ): strin
 		return __( 'Expand your business with iDEAL — Netherlands\'s most popular payment method.', 'woocommerce-payments' );
 	}
 
-	/**
-	 * Is the payment method a BNPL (Buy Now Pay Later) payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_bnpl(): bool {
-		return PaymentMethodUtils::is_bnpl( self::get_capabilities() );
-	}
-
-	/**
-	 * Is the payment method a reusable payment method?
-	 *
-	 * @return boolean
-	 */
-	public static function is_reusable(): bool {
-		return PaymentMethodUtils::is_reusable( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method accept only domestic payments?
-	 *
-	 * @return boolean
-	 */
-	public static function accepts_only_domestic_payments(): bool {
-		return PaymentMethodUtils::accepts_only_domestic_payments( self::get_capabilities() );
-	}
-
-	/**
-	 * Does the payment method allow manual capture?
-	 *
-	 * @return boolean
-	 */
-	public static function allows_manual_capture(): bool {
-		return PaymentMethodUtils::allows_manual_capture( self::get_capabilities() );
-	}
-
 	/**
 	 * Get the list of supported currencies
 	 *
@@ -207,15 +171,6 @@ public static function is_available_for( string $currency, string $account_count
 		return PaymentMethodUtils::is_available_for( self::get_supported_currencies(), self::get_supported_countries(), $currency, $account_country );
 	}
 
-	/**
-	 * Whether this payment method should be enabled by default
-	 *
-	 * @return bool
-	 */
-	public static function is_enabled_by_default(): bool {
-		return false;
-	}
-
 	/**
 	 * Get the minimum amount for this payment method for a given currency and country
 	 *