-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codepen implemention link added #20
base: master
Are you sure you want to change the base?
Codepen implemention link added #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's wait for @plxity to resolve merge conflicts.
@plxity Kindly review |
@yellowwoods12 @plxity Kindly review this PR, It's been more than a month. |
README.md
Outdated
@@ -23,3 +23,6 @@ You can run tests by `npm test`, which would launch the test runner in the inter | |||
## Deployment | |||
|
|||
To build the website, run `npm run build` . This would create a new `public` folder, which can be used to deploy the app on a production server. | |||
|
|||
## Code Pen Implemention Link | |||
Check [this](https://codepen.io/) for implemention purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No link is present, can you please check again?
@plxity Is it fine now.? I guess there were some merge conflicts before |
@plxity any update on this pr ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
@@ -24,5 +24,7 @@ You can run tests by `npm test`, which would launch the test runner in the inter | |||
|
|||
To build the website, run `npm run build` . This would create a new `public` folder, which can be used to deploy the app on a production server. | |||
|
|||
## Code Pen Implemention Link | |||
Check [this](https://codepen.io/) for implemention purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyakapoor08 Still no link is present. Please check.
is this not the link? |
Link to what? Do you want the user to redirect to codepen website? |
As the issue states, add codepen implementation link. So this link doesn't have any implementation? I hope I'm clear. |
@shreyakapoor08 This issue requires the implementation of this website on codepen and that link has to be added in the Readme.md. |
@plxity @yellowwoods12 Please check now, is it fine ? |
Fixes #17
Codepen implemention link added.