-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-flow CLI #10
git-flow CLI #10
Conversation
This is great! Personally, I don't mind adding the cli to this project (as long as it never causes the API to change) but I can think of a couple reasons why you might want to make it a separate thing. With your own repo/package, you'd be able to give the project a more concise description and name so potential users would have an easier time finding your project. Secondly, most users of nodegit-flow are going to be using it either through the cli or JS, not both. That means sifting through docs will be a bit tougher since you'd have to first find the section that refers to the API you're using. Overall I think it'd be less confusing to users if we kept the two separate. But like I said I'm open to the idea. Let me know if there are any advantages I'm not seeing. |
src/bin/git-flow.js
Outdated
@@ -0,0 +1,148 @@ | |||
#!/usr/bin/env devtool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to #!/usr/bin/env node
src/bin/git-flow.js
Outdated
else if(type === 'release') { | ||
return Git.Flow.startRelease(repo, name); | ||
} | ||
else if(type === 'hofix') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo hotfix
@MadLittleMods don't know if this helps, but I started working on something similar myself: https://github.com/Kibibit/kibibit-cli It's currently not stable (I'm in the middle of writing it :-)), and it's also coupled with github (by a single file called It's not vanilla nodegit-flow (I do some extra stuff, like creating a repo on init if you're not already inside a git repo), but might suite your needs |
Closing as it looks like this was built into
Works for me 👍
|
Fixes #9
git-flow CLI.
Still WIP but would love some discussion/suggestions on the direction this should go. If we want to suss this out through chat, I am available on Gitter but would be great to create a
nodegit-flow
specific room to keep the discussion out in the open. This could end up as a separate package if we don't want the CLI added here.The reason for this over some of the other CLI options out there is so that there is an option on Windows that doesn't require cygwin. Plus JavaScript based 👍
Todo
console.log
?finish
mergeCommit.id()
doesn't work as documented 😕publish
push
(maybe)