Skip to content

Commit 8f5a5e8

Browse files
Copilotpamelafox
andcommitted
Remove GITHUB_BASE_URL env var and hard-code GitHub Models URL
Co-authored-by: pamelafox <[email protected]>
1 parent 5012cd4 commit 8f5a5e8

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

.env.sample

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ OLLAMA_EMBED_MODEL=nomic-embed-text
3737
OLLAMA_EMBEDDING_COLUMN=embedding_nomic
3838
# Needed for GitHub Models:
3939
GITHUB_TOKEN=YOUR-GITHUB-TOKEN
40-
GITHUB_BASE_URL=https://models.github.ai/inference
4140
GITHUB_MODEL=openai/gpt-4o
4241
GITHUB_EMBED_MODEL=openai/text-embedding-3-large
4342
GITHUB_EMBED_DIMENSIONS=1024

src/backend/fastapi_app/openai_clients.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,10 @@ async def create_openai_chat_client(
5454
)
5555
elif OPENAI_CHAT_HOST == "github":
5656
logger.info("Setting up OpenAI client for chat completions using GitHub Models")
57-
github_base_url = os.getenv("GITHUB_BASE_URL", "https://models.github.ai/inference")
5857
github_model = os.getenv("GITHUB_MODEL", "openai/gpt-4o")
59-
logger.info(f"Using GitHub Models with base URL: {github_base_url}, model: {github_model}")
58+
logger.info(f"Using GitHub Models with model: {github_model}")
6059
openai_chat_client = openai.AsyncOpenAI(
61-
base_url=github_base_url,
60+
base_url="https://models.github.ai/inference",
6261
api_key=os.getenv("GITHUB_TOKEN"),
6362
)
6463
else:
@@ -114,11 +113,10 @@ async def create_openai_embed_client(
114113
)
115114
elif OPENAI_EMBED_HOST == "github":
116115
logger.info("Setting up OpenAI client for embeddings using GitHub Models")
117-
github_base_url = os.getenv("GITHUB_BASE_URL", "https://models.github.ai/inference")
118116
github_embed_model = os.getenv("GITHUB_EMBED_MODEL", "openai/text-embedding-3-small")
119-
logger.info(f"Using GitHub Models with base URL: {github_base_url}, embedding model: {github_embed_model}")
117+
logger.info(f"Using GitHub Models with embedding model: {github_embed_model}")
120118
openai_embed_client = openai.AsyncOpenAI(
121-
base_url=github_base_url,
119+
base_url="https://models.github.ai/inference",
122120
api_key=os.getenv("GITHUB_TOKEN"),
123121
)
124122
else:

tests/test_openai_clients.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ async def test_github_models_configuration(monkeypatch):
3232
monkeypatch.setenv("OPENAI_CHAT_HOST", "github")
3333
monkeypatch.setenv("OPENAI_EMBED_HOST", "github")
3434
monkeypatch.setenv("GITHUB_TOKEN", "fake-token")
35-
# Don't set GITHUB_BASE_URL or GITHUB_MODEL to test defaults
35+
# Don't set GITHUB_MODEL to test defaults
3636

3737
# Test chat client configuration
3838
chat_client = await create_openai_chat_client(None)
@@ -57,7 +57,6 @@ async def test_github_models_with_custom_values(monkeypatch):
5757
monkeypatch.setenv("OPENAI_CHAT_HOST", "github")
5858
monkeypatch.setenv("OPENAI_EMBED_HOST", "github")
5959
monkeypatch.setenv("GITHUB_TOKEN", "fake-token")
60-
monkeypatch.setenv("GITHUB_BASE_URL", "https://custom.github.ai/inference")
6160
monkeypatch.setenv("GITHUB_MODEL", "openai/gpt-4")
6261
monkeypatch.setenv("GITHUB_EMBED_MODEL", "openai/text-embedding-ada-002")
6362

0 commit comments

Comments
 (0)