Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Refresh interval failed to work when there is only feature flag refresh is configured #632

Open
zhiyuanliang-ms opened this issue Mar 3, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@zhiyuanliang-ms
Copy link
Contributor

A bug reported by our customer #527

Code

_nextCollectionRefreshTime will not be set if key value refresh is not configured (kvCollectionRefreshInterval will be null). This line will always set the current time as the next refresh due which will cause refresh is always due.

The result is that if user only enabled the feature flag refresh and set a refresh interval for feature flag, each time calling TryRefreshAsync, the refresh operation will always send requests. But the refresh will happen every time.

@zhiyuanliang-ms zhiyuanliang-ms added the bug Something isn't working label Mar 3, 2025
@zhiyuanliang-ms zhiyuanliang-ms changed the title BUG: BUG: Refresh interval failed to work when there is only feature flag refresh is configured Mar 3, 2025
@samsadsam samsadsam assigned samsadsam and amerjusupovic and unassigned samsadsam Mar 3, 2025
@amerjusupovic
Copy link
Member

amerjusupovic commented Mar 3, 2025

@jimmyca15 helped investigate offline, this does not manifest into an actual bug to users because of how the list of key-values and flags that need refresh are set on these lines. The provider normally requests app config for each watcher as it iterates over the list, but because the list is empty no additional calls are made. This logic still needs an update though, and a PR with the changes will be up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants