Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to refresh keys automatically without using sentinel #40

Open
nosalan opened this issue May 7, 2024 · 2 comments
Open

Unable to refresh keys automatically without using sentinel #40

nosalan opened this issue May 7, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nosalan
Copy link

nosalan commented May 7, 2024

I have problem with receiving updates made in a Configuration Explorer. I don't want to use sentinel keys, I would like my provider to consume updates to all configuration values but the Config Map is not refreshed upon adding and updating configuration settings.
I tried specifying something like this but the error is: spec.configuration.refresh.monitoring: Required value

apiVersion: azconfig.io/v1
kind: AzureAppConfigurationProvider
  name: <REDACTED>
  namespace: demo
spec:
  auth:
    workloadIdentity:
      managedIdentityClientId: <REDACTED>
  configuration:
    refresh:
      enabled: true
      interval: 30s
    selectors:
    - keyFilter: '*'

The documentation says that you can use a key-value to signal the completion of your update. This key-value is known as the sentinel key. Seems that it's something that you must use in order to consume the updates of all keys, not something you can use. Am I correct?

I expected the functionality to download updates to all configuration keys and their updates as the fundamental functionality of the provider but maybe I'm doing something wrong.

@RichardChen820
Copy link
Contributor

Sentinel key is required for refreshing now, the feature of refreshing by watching all keys is in our roadmap. Although we don't have an ETA of having this feature, it won't take very long I think.

@RichardChen820 RichardChen820 self-assigned this May 7, 2024
@RichardChen820 RichardChen820 added the enhancement New feature or request label May 7, 2024
@RichardChen820 RichardChen820 added the good first issue Good for newcomers label May 7, 2024
@linglingye001
Copy link
Contributor

Hi @nosalan , refresh by watching all keys is supported in v2.1.0 , where sentinel keys are not required. You can refer the releaseNotes for more information. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants