Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS Key Vault references generating opaque not tls secrets #81

Open
trhumphries opened this issue Nov 8, 2024 · 4 comments
Open

TLS Key Vault references generating opaque not tls secrets #81

trhumphries opened this issue Nov 8, 2024 · 4 comments

Comments

@trhumphries
Copy link

I have a reference to a certificate in a KV with the .kubernetes.secret.type set to kubernetes.io/tls. However instead of a tls secret it generates an opaque secret. This did work 2 days ago the latest 2.0.0 update seems to have broken it.

@trhumphries
Copy link
Author

BTW, I just tried the 2.1.0 release and it also creates as an opaque secret

@trhumphries
Copy link
Author

Not sure if this will help. If I change the target.secretName to point to a non-existant value in the App Configuration. It hone generates 2 secrets one called nonexistantsecret that is of type opaque and one with the name of the certificate from the KV that is of type tls

secret:
auth:
workloadIdentity:
serviceAccountName: appconfigidentity
target:
secretName: nonexistantsecret

@linglingye001
Copy link
Contributor

linglingye001 commented Nov 11, 2024

Hi @trhumphries , this behavior is expected. The spec.secret and spec.secret.target are required if any Key Vault references are expected to be downloaded. By default, Secrets resolved from Key Vault references (without .kubernetes.secret.type specified) are saved as the Opaque Secret type with target.secretName.

@RichardChen820
Copy link
Contributor

RichardChen820 commented Nov 11, 2024

The one that has got the .kubernetes.secret.type: kubernetes.io/tls tag is saved as tls type secret, since there's no other secret selected, an empty opaque secret is generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants