Skip to content

Throwing an error while HTTP streaming is enabled causes response to never be sent #324

@nimobeeren

Description

@nimobeeren

Description

When HTTP streaming is enabled with app.setup({ enableHttpStream: true }), throwing any error causes the the response to never be sent and never logging anything.

Expected behavior

Throwing an error causes a response with status 500 to be sent and the error to be logged, same as when HTTP streaming is disabled.

Reproduction

import {
  app,
  type HttpRequest,
  type InvocationContext,
  type HttpResponseInit,
} from "@azure/functions";

app.setup({ enableHttpStream: true });

app.http("proxy", {
  methods: ["POST"],
  handler: proxy,
});

export async function proxy(
  request: HttpRequest,
  context: InvocationContext
): Promise<HttpResponseInit> {
  throw new Error("Kaboom! 💣");
}

Setting enableHttpStream: false results in the expected behavior, but then streaming won't work.

Activity

nimobeeren

nimobeeren commented on Jan 8, 2025

@nimobeeren
Author

As a workaround, I'm wrapping my main handler in a try/catch. But this should be handled by the library IMO.

app.http("proxy", {
  methods: ["POST"],
  handler: safeProxy,
});

export async function safeProxy(
  request: HttpRequest,
  context: InvocationContext
): Promise<HttpResponseInit> {
  try {
    return await proxy(request, context);
  } catch (error) {
    context.error(error);
    return { status: 500 };
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @nimobeeren

        Issue actions

          Throwing an error while HTTP streaming is enabled causes response to never be sent · Issue #324 · Azure/azure-functions-nodejs-library