[Eng] Fix syntax in version controller (#28371)

Author: VeryEarly

tools/VersionController/Models/ModuleHelper.cs

@@ -16,16 +16,14 @@ internal static string GetLatestVersionFromPSGallery(string moduleName, ReleaseT
         {
             string version = null;
             string findModuleScript;
+            string authScript = "";
 
             if (!string.IsNullOrEmpty(System.Environment.GetEnvironmentVariable("DEFAULT_PS_REPOSITORY_URL")))
             {
                 string repository = System.Environment.GetEnvironmentVariable("DEFAULT_PS_REPOSITORY_NAME");
-                findModuleScript = @"
-$AccessTokenSecureString = $env:SYSTEM_ACCESS_TOKEN | ConvertTo-SecureString -AsPlainText -Force;
-$credentialsObject = [pscredential]::new('ONEBRANCH_TOKEN', $AccessTokenSecureString);
-";
-                findModuleScript += releaseType == ReleaseType.STS 
-                    ? $"Find-PSResource -Name {moduleName} -Repository {repository} -Version * -Credential $credentialsObject" 
+                authScript += "$AccessTokenSecureString = $env:SYSTEM_ACCESS_TOKEN | ConvertTo-SecureString -AsPlainText -Force;$credentialsObject = [pscredential]::new('ONEBRANCH_TOKEN', $AccessTokenSecureString);";
+                findModuleScript = releaseType == ReleaseType.STS
+                    ? $"Find-PSResource -Name {moduleName} -Repository {repository} -Version * -Credential $credentialsObject"
                     : $"Find-PSResource -Name Az -Repository {repository} -Version * -Credential $credentialsObject";
             }
             else
@@ -34,9 +32,9 @@ internal static string GetLatestVersionFromPSGallery(string moduleName, ReleaseT
                 findModuleScript = releaseType == ReleaseType.STS ? $"Find-PSResource -Name {moduleName} -Repository {repository} -Version *" : $"Find-PSResource -Name Az -Repository {repository} -Version *";
             }
             string filterRequiredReleaseTypeScript = releaseType == ReleaseType.STS ? "" : "| Where-Object {([System.Version]($_.Version)).Major % 2 -eq 0}";
-            string sortModuleScript = "| Sort-Object {[System.Version]($_.Version)} -Descending";
+            string sortModuleScript = "| Sort-Object {[System.Version]$_.Version} -Descending";
             string getLastModuleVersionScript = releaseType == ReleaseType.STS ? 
-                $"({findModuleScript}{filterRequiredReleaseTypeScript}{sortModuleScript})[0].Version" :
+                $"{authScript}({findModuleScript}{filterRequiredReleaseTypeScript}{sortModuleScript})[0].Version" :
                 $"(({findModuleScript}{filterRequiredReleaseTypeScript}{sortModuleScript})[0].Dependencies | Where-Object {{$_.Name -eq '{moduleName}'}})[1]";
             using (PowerShell powershell = PowerShell.Create())
             {