-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Maps] Traffic Incident 2025-01-01 #31578
base: main
Are you sure you want to change the base?
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/1.0 to stable/2025-04-01.
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
5c50b3c
to
86d4a16
Compare
86d4a16
to
ad4e15d
Compare
specification/maps/data-plane/Traffic/stable/2025-01-01/traffic.json
Outdated
Show resolved
Hide resolved
specification/maps/data-plane/Traffic/stable/2025-01-01/traffic.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left comments on a few minor problems -- should be very easy to fix.
specification/maps/data-plane/Traffic/stable/2025-01-01/traffic.json
Outdated
Show resolved
Hide resolved
specification/maps/data-plane/Traffic/stable/2025-01-01/traffic.json
Outdated
Show resolved
Hide resolved
specification/maps/data-plane/Traffic/stable/2025-01-01/traffic.json
Outdated
Show resolved
Hide resolved
specification/maps/data-plane/Traffic/stable/2025-01-01/traffic.json
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
@mikekistler Is there any other outstanding item we need to take care of before this can be ready to merge? As you know there was a separate conversation on the breaking change review, so I want to make sure we have all the feedback in this PR. Thank you! |
"type": "string" | ||
}, | ||
"isRoadClosed": { | ||
"description": "A value of 'true' indicates that there is a road closure.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use true
instead of 'true' here?
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.fix #31596