[EngSys] Enable CodeQL for JavaScript and Actions #33060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mikeharder
commented
Mar 6, 2025
•
mikeharder
commented
- Fixes [EngSys] Enable CodeQL for Actions #33023
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
mikeharder
commented
Mar 6, 2025
mikeharder
commented
Mar 6, 2025
mikeharder
changed the title
benbp
reviewed
Mar 6, 2025
| pull_request: | ||
| branches: [ "main", "release-*" ] | ||
| schedule: | ||
| - cron: '27 4 * * 1' |
There was a problem hiding this comment.
This was the default when GH created the file for me. Maybe random, or the time I created the file? Can change to a more "standard" time if we want.
benbp
reviewed
Mar 6, 2025
Comment on lines
+47
to
+49
| config: | | ||
| paths: | ||
| - .github |
There was a problem hiding this comment.
Is this supposed to be a multi line string?
There was a problem hiding this comment.
config is a multi-line string. paths is a list.
weshaggard
reviewed
Mar 6, 2025
.github/workflows/codeql.yml
Outdated
| @@ -47,12 +47,17 @@ jobs: | |||
| config: | | |||
| paths: | |||
| - .github | |||
| sparse-checkout: | | |||
| .github | |||
There was a problem hiding this comment.
Is this to scope to only the github folder? Do we not want any other validation?
If we do want to scope it might be worth mentioning that here in a comment.
weshaggard
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.