Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] ModelValidation, SemanticValidation, and BreakingChanges should ignore common-types #33056

Open
mikeharder opened this issue Mar 6, 2025 · 0 comments
Assignees

Comments

@mikeharder
Copy link
Member

mikeharder commented Mar 6, 2025

PR: #33043

Checks ModelValidation, SemanticValidation, and BreakingChanges are all failing, because they consider the changes to specification/common-types as "spec changes" and try to validate the files, which always fails since they're aren't complete specs.

Fix is to exclude /specification/common-types/** and /*.json (json files in repo root) when detecting spec files to analyze.

@mikeharder mikeharder self-assigned this Mar 6, 2025
@mikeharder mikeharder moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🤖🧠 Mar 6, 2025
@mikeharder mikeharder moved this from 🔬 Dev in PR to 🐝 Dev in Azure SDK EngSys 🤖🧠 Mar 6, 2025
@mikeharder mikeharder moved this from 🐝 Dev to 📋 Backlog in Azure SDK EngSys 🤖🧠 Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant