Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec-gen-sdk-runner] Remove dependency from unit tests to specification/contosowidgetmanager #33071

Open
mikeharder opened this issue Mar 7, 2025 · 0 comments
Assignees

Comments

@mikeharder
Copy link
Member

mikeharder commented Mar 7, 2025

The unit tests currently depend on specification/contosowidgetmanager, which is undesirable for a few reasons:

  1. You need to clone this folder to run the tests. The tool isn't self-contained.
    sparse-checkout-paths: |
    specification/common-types
    specification/contosowidgetmanager
  2. Changes to the sample could break your tests. These should be decoupled.
  3. Your tests fail in RPSaaSMaster, since this branch doesn't have the contoso data-plane. (example: https://github.com/Azure/azure-rest-api-specs-pr/actions/runs/13711484022)

Please update your tests to use a sample spec under your own test folder. This could even be a copy of contoso if you want.
Example:

https://github.com/Azure/azure-rest-api-specs/tree/main/eng/tools/typespec-requirement/test/specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants