You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This particular condition for autosignoff actually makes sense for all PRs including TypeSpec ones and I have this in the backlog. We can start by enabling this for TypeSpec first and then expand to all other PRs later.
mikeharder
changed the title
[ARM Incremental TypeSpec] PR includes only changes to readme.md
[ARM Incremental TypeSpec] PR includes only changes to readme or examples
Mar 8, 2025
@rkmanda: Similar, what if a PR only changes examples? Currently the check returns "false", but I think it should return "true", at least for existing TSP specs. Change to readme.md or examples clearly seem like safe "incremental changes".
mikeharder
changed the title
[ARM Incremental TypeSpec] PR includes only changes to readme or examples
[ARM Incremental TypeSpec] PR only includes changes to readme or examples
Mar 8, 2025
If a PR includes only changes to
readme.md
in a TypeSpec spec, shouldARM Incremental TypeSpec
trigger and return true? Currently, it does not.Example: #33067
Changing the check to do so, should be simple. Just include
readme.md
when finding changed files underresource-manager
.@rkmanda: What do you think?
The text was updated successfully, but these errors were encountered: