Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM Incremental TypeSpec] PR only includes changes to readme or examples #33082

Open
mikeharder opened this issue Mar 7, 2025 · 2 comments
Open
Assignees

Comments

@mikeharder
Copy link
Member

mikeharder commented Mar 7, 2025

If a PR includes only changes to readme.md in a TypeSpec spec, should ARM Incremental TypeSpec trigger and return true? Currently, it does not.

Example: #33067

Changing the check to do so, should be simple. Just include readme.md when finding changed files under resource-manager.

@rkmanda: What do you think?

@mikeharder mikeharder self-assigned this Mar 7, 2025
@mikeharder mikeharder moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🤖🧠 Mar 7, 2025
@rkmanda
Copy link
Member

rkmanda commented Mar 7, 2025

This particular condition for autosignoff actually makes sense for all PRs including TypeSpec ones and I have this in the backlog. We can start by enabling this for TypeSpec first and then expand to all other PRs later.

@mikeharder mikeharder changed the title [ARM Incremental TypeSpec] PR includes only changes to readme.md [ARM Incremental TypeSpec] PR includes only changes to readme or examples Mar 8, 2025
@mikeharder
Copy link
Member Author

@rkmanda: Similar, what if a PR only changes examples? Currently the check returns "false", but I think it should return "true", at least for existing TSP specs. Change to readme.md or examples clearly seem like safe "incremental changes".

@mikeharder mikeharder changed the title [ARM Incremental TypeSpec] PR includes only changes to readme or examples [ARM Incremental TypeSpec] PR only includes changes to readme or examples Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants