-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Release machinelearningservices microsoft.machine learning services 2025 12 01 #38837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release machinelearningservices microsoft.machine learning services 2025 12 01 #38837
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2025-09-01 to stable/2025-12-01.
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
No changes between this API version and the previous API version. However, we still need to release this API version as Microsoft.MachineLearningServices API versions must line up with Microsoft.CognitiveServices, who will also be releasing a 2025-12-01 version |
nit - Remove Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2025-12-01/machineLearningServices.json:263 in 851e0b3. [](commit_id = 851e0b3, deletion_comment = False) |
Use v6 unless there is a need to stay at v3. Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2025-12-01/machineLearningServices.json:46 in 851e0b3. [](commit_id = 851e0b3, deletion_comment = False) |
Applies to all other enums. In reply to: 3564805938 Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2025-12-01/machineLearningServices.json:2492 in 851e0b3. [](commit_id = 851e0b3, deletion_comment = False) |
nit - For consistency, let us end the description text with a period. Applies to all occurrences in the specs. Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2025-12-01/machineLearningServices.json:2798 in 851e0b3. [](commit_id = 851e0b3, deletion_comment = False) |
Replace with Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2025-12-01/machineLearningServices.json:3493 in 851e0b3. [](commit_id = 851e0b3, deletion_comment = False) |
|
Please address 'Swagger Avocado' errors. |
The controller servicing this route does not differentiate based on API version, updating the description here would cause an incongruency between this API version and previous API versions |
The controller servicing this route does not differentiate based on API version, updating the description here would cause an incongruency between this API version and previous API versions |
Looks to be an almost 4 year old inconsistency on both swagger and service side code, would require service side code changes. Will initiate a discussion with owners |
Will leave these enum values as is for consistency |
Good question, I created a work item to discuss this with code owner for next api version: Bug 4843851: idleTimeBeforeShutdown string format discussion |
Azure machine learning |
Created a work item for this discussion here: Bug 4843851: idleTimeBeforeShutdown string format discussion |
The swagger avocado will need approval from ARM reviewer team, this needed ARM approval on previous PRs as well. For example: |
|
@fmabroukmsft - You should be able to update descriptions without any issues, even if your service doesn't currently distinguish API versions (should only affect the docs). Likewise adding a date-time format requirement to a string type is a cross-platform client breaking change but shouldn't affect the service which is already (presumably) validating that string is a date-time. I'm signing off for ARM, since we don't generally require changes to APIs that have shipped in an earlier API version. Please consider the feedback, but it's not blocking. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.